Level of logging about lua-resty-waf HOT 5 CLOSED

Debug statements are most useful when debugging, obviously- those particular statements have been useful in catching mistakes and identifying issues I didn't know where around. Perhaps its time to add some configurable granularity to debug logs?

from lua-resty-waf.

Yes and no, its debug logs so they can be a bit verbose. Granularity might be an overkill. Personally I just think logging inside utility functions i.e the _table_ functions to be redundant. These functions should instead be rigorously tested. Application specific logging can then occur outside if necessary.

This also allows for these utility functions to be used in the module context where options are unavailable. I found I needed to do this in my branch a few times (e.g _table_clone on the default options)

from lua-resty-waf.

I agree with splitice. Some logging is unnecessary, and I think _log should supply for log level directly, as for the logging content, we should write it before thinking about seriously.

from lua-resty-waf.

"Personally I just think logging inside utility functions i.e the table functions to be redundant. These functions should instead be rigorously tested. Application specific logging can then occur outside if necessary."

Yep, the more I look at this, this more I agree. Once I finish breaking out lookup tables and various functions into smaller libraries, we can start unit testing with something like Test::Nginx::Socket::Lua, and the nasty debug logs can go away.

from lua-resty-waf.

More work done on this in:

b814a42
feb5763
493391d

If there are suggestions on cleaning this further, feel free to submit a PR :)

from lua-resty-waf.