Git Product home page Git Product logo

Comments (7)

nvuillam avatar nvuillam commented on August 16, 2024 1

@wesley-dean-flexion i'll add it when releasing, that's ok :)

from megalinter.

wesley-dean-flexion avatar wesley-dean-flexion commented on August 16, 2024 1

Thank you.

from megalinter.

wesley-dean-flexion avatar wesley-dean-flexion commented on August 16, 2024

https://github.com/oxsecurity/megalinter/blob/main/.automation/build.py#L2287-L2290 is where the JSON schema is generated when stuff is added

from megalinter.

nvuillam avatar nvuillam commented on August 16, 2024

Some parts of the json schema are manually added, and we forgot to add this variable, good catch :)

Would u like to make a PR ? :)

Meanwhile, you can use YAML_V8R_FILTER_REGEX_EXCLUDE

from megalinter.

wesley-dean-flexion avatar wesley-dean-flexion commented on August 16, 2024

make a PR?
Please!

Next, I started looking through the repo for instances of something that made it into the schema (_ARGUMENTS) and something that didn't (_RULESETS) to try to figure out where it could be added. Given your comment, I obviously wasn't successful with this approach. :)

[wdean@yaoguai ~/src/megalinter][04:38 PM] (main) $ ack -li REPOSITORY_SEMGREP_ARGUMENTS
docs/descriptors/repository_semgrep.md
docs/json-schemas/configuration.html
megalinter/descriptors/schemas/megalinter-configuration.jsonschema.json
megalinter/linters/SemgrepLinter.py
site/descriptors/repository_semgrep/index.html
site/json-schemas/configuration.html
site/search/search_index.json
[wdean@yaoguai ~/src/megalinter][04:38 PM] (main) $ ack -li REPOSITORY_SEMGREP_RULESET
CHANGELOG.md
docs/descriptors/repository_semgrep.md
megalinter/descriptors/repository.megalinter-descriptor.yml
megalinter/linters/SemgrepLinter.py
site/CHANGELOG/index.html
site/descriptors/repository_semgrep/index.html
site/search/search_index.json

(including this so if someone else should come behind me, they might see what did (or didn't) work)

from megalinter.

wesley-dean-flexion avatar wesley-dean-flexion commented on August 16, 2024

https://github.com/oxsecurity/megalinter/blob/main/megalinter/descriptors/schemas/megalinter-configuration.jsonschema.json#L14266

 "REPOSITORY_SEMGREP_ARGUMENTS": {
      "$id": "#/properties/REPOSITORY_SEMGREP_ARGUMENTS",
      "description": "REPOSITORY_SEMGREP: User custom arguments to add in linter CLI call",
      "examples:": [
        "--foo",
        "bar"
      ],
      "items": {
        "type": "string"
      },
      "title": "REPOSITORY_SEMGREP: Custom arguments",
      "type": [
        "array",
        "string"
      ]
    },

^ currently exists

 "REPOSITORY_SEMGREP_RULESETS": {
      "$id": "#/properties/REPOSITORY_SEMGREP_RULESETS",
      "description": "REPOSITORY_SEMGREP: Specify custom ruleset(s) for semgrep",
      "examples:": [
        "auto",
        "p/ci"
      ],
      "items": {
        "type": "string"
      },
      "title": "REPOSITORY_SEMGREP: Custom arguments",
      "type": [
        "array",
        "string"
      ]
    },

^ proposed addition

@nvuillam something like that?

from megalinter.

wesley-dean-flexion avatar wesley-dean-flexion commented on August 16, 2024

see #3164

I didn't add an entry to the changelog as the update was a trivial bug fix. I can add something if you want.

from megalinter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.