ast-codegen: support `#[visit(enter_before)]` attribute about oxc HOT 3 CLOSED

Ah, Haha. This is also a bit confusing for visit orders. I thought about it again. We can defer binding FunctionExpression and ClassExpression and bind them when we visit BindingIdentifier.

from oxc.

@Dunqing Just to throw in my 2 cents, I wonder if FunctionExpression and FunctionDeclaration should be separate types (and each type would have Function as a field within it). The 2 have various significant differences:

1. One is a Statement, the other an Expression.
2. FunctionExpression's name field should be an Option, whereas it's compulsory in FunctionDeclaration.
3. Scope should be entered before name for FunctionExpression and after name for FunctionDeclaration.

We could also have a separate type for ObjectMethod (whose name isn't a binding at all).

At present, it's possible to create non-sensical AST nodes (e.g. a FunctionDeclaration with no name) - it'd be good to make this impossible through the type system.

from oxc.

@Dunqing Just to throw in my 2 cents, I wonder if FunctionExpression and FunctionDeclaration should be separate types (and each type would have Function as a field within it). The 2 have various significant differences:

1. One is a Statement, the other an Expression.
2. FunctionExpression's name field should be an Option, whereas it's compulsory in FunctionDeclaration.
3. Scope should be entered before name for FunctionExpression and after name for FunctionDeclaration.

We could also have a separate type for ObjectMethod (whose name isn't a binding at all).

At present, it's possible to create non-sensical AST nodes (e.g. a FunctionDeclaration with no name) - it'd be good to make this impossible through the type system.

Yes, I talked with @Boshen about the above. Since they are not very different, they have been combined into one type. I agree we should have different types for FunctionExpression and FunctionDeclaration, and also class should be ClassExpression and ClassDeclaration

3. Scope should be entered before name for FunctionExpression and after name for FunctionDeclaration.

We bind in enter_node. So we have to switch the order of enter_node and enter_scope to bind it to the corresponding scope. Or do something like #4195 (comment).

from oxc.