Handle `@jsx` pragmas for TypeScript about oxc HOT 9 CLOSED

It should be analyzed in the transformer.

from oxc.

Would it not be useful to add a pragmas field to Program and populate it in the parser, like with Hashbang? I imagine other tools might find this info useful as its meaningful information for interpreting the AST (broadly equivalent to an import React from "whatever"; statement).

from oxc.

Nope, it's not part of the spec so it can't go into the AST.

from oxc.

But it is part of the TS spec, no? https://www.typescriptlang.org/docs/handbook/jsx.html#configuring-jsx

from oxc.

That's not an AST spec, it's just documentation 😅

from oxc.

OK, true! But what's the difference? Spec and config are both things which are present in the source text, and alter the meaning of the code.

Therefore I feel it's better to store that useful info in AST. And we have to parse it somewhere, so might as well parse it in the parser. But I don't feel strongly about it - say no one more time, and I'll shut up!

from oxc.

PS It'd also be faster to find these comments in parser while parsing comments anyway, rather than searching through all comments again later.

from oxc.

You can save them into Trivias if you really want to parse them from the parser.

from oxc.

In #3553

The lines in https://github.com/microsoft/TypeScript/blob/main/tests/cases/compiler/jsxComplexSignatureHasApplicabilityError.tsx

// @strict: true
// @jsx: react
// @skipLibCheck: true

are compiler settings for the test file, they aren't pragmas.

In tsx files, the prgrama

/** @jsxImportSource preact */

<Foo />

produces

import {jsx as _jsx} from 'preact/jsx-runtime';
_jsx(Foo, {});

which is working as intended.

from oxc.