linter: rules we want to implement about oxc HOT 12 CLOSED

Seems like bad-string-regex-arg not exist in Deepscan, is it bad-regexp-literal-in-string?

Oops, I combined these two:

• https://deepscan.io/docs/rules/bad-replace-all-arg
• https://deepscan.io/docs/rules/bad-match-all-arg

since they are the same thing

from oxc.

@mysteryven You can also implement any deepscan rule that interest you 😁

from oxc.

@mysteryven thanks but, for example, I am not seeing deprecated rules like no-catch-shadow which are still supported by ESLint; It's probably a WIP/incomplete list.

Aha, the deprecated rules are folded, search the "Deprecated rules" and click the right arrow :)

from oxc.

May I pick some rules to implement?

from oxc.

Some interesting rules:

• no-irregular-whitespace - we can use the lexer to store these inside trivias
• no-unused-labels - build this inside the semantic analyzer
• require-yield - inside the semantic analyzer, keep track of functions and then mark the function node with a NodeFlag::HasYield when we see a yield
• bad-xxx - these are the rules from deepscan, you can find their descriptions here: https://deepscan.io/docs/rules/

from oxc.

• require-yield - inside the semantic analyzer, keep track of functions and then mark the function node with a NodeFlag::HasYield when we see a yield

I just realized that if we have

var a = 1;
function *a() { return; }

The symbol table only stores the first var a = 1 declaration? Then it's not guaranteed we can check all the functions by just looking at the symbols.

from oxc.

The symbol table only stores

You visit the functions inside the linter, and then lookup the symbol via the node. But we need #225

Or we figure out all the edge cases for symbol declaration, which is really nasty ... I tried to follow TypeScript a while back, and I couldn't follow all the cases 😢

from oxc.

Seems like bad-string-regex-arg not exist in Deepscan, is it bad-regexp-literal-in-string?

from oxc.

I'm going to create another list for this.

from oxc.

Is there a list compiled of all the unimplemented ESLint rules?
Do I have compare the core rules with https://github.com/oxc-project/oxc/blob/main/crates/oxc_linter/src/rules.rs#L39?

from oxc.

Is there a list compiled of all the unimplemented ESLint rules? Do I have compare the core rules with main/crates/oxc_linter/src/rules.rs#L39?

This issue is a list of rule's implementation status : #479

from oxc.

@mysteryven thanks but, for example, I am not seeing deprecated rules like no-catch-shadow which are still supported by ESLint; It's probably a WIP/incomplete list.

from oxc.