improve code quality about joomscan HOT 6 OPEN

I have sent a PR.
The change looks huge, but the code changes are little.
all I did is:

• put sub {} around the exisiting code
• put that code in modules
• made global variables private
• modified joomla.pl, to make it work

I resisted the urge to fix/cleanup more.
This way you can easier follow what I did.

from joomscan.

ok. Great. I will refactor the code. When I'm done I will send a PR.
Since I have a day job, this may last some days

from joomscan.

Hello @StPanning,

Thanks for your contribution, I will review your code after BH Arsenal Singapore. the details you shared is very useful.

Best Regards.

from joomscan.

Hello,

It's actually a great idea, if we want to focus on rewriting things, we may also write a cleaner code, with self-documentation. I believe it's a great idea to use perlpod too.

despite we must have a release for tomorrow #19, let's just fix simple issues for release 0.0.5 and apply this changes for 0.0.6 release.

@rezasp please review and let us know if you agree.

Best Regards.

from joomscan.

Hello,

Thank you for sharing us your great idea, I agree, I am working on a few enhancements for tomorrow, and let you know when I'm finished.

Regards.

from joomscan.

Hey,

thanks for updating us. be in touch (Y).

regards.

from joomscan.