make test crash when using pcre jit about modsecurity HOT 5 CLOSED

Hello Rainer,

I cannot reproduce this issue. Could you tell me what pcre version and linux distro you are using ?
Thanks

from modsecurity.

Can you try replace the *errmsg in re_operators.c to:

                *error_msg = apr_psprintf(rule->ruleset->mp,
                        "Rule %pp [id \"%s\"][file \"%s\"][line \"%d\"] - "
                        "Execution error - "
                        "Does not support JIT (%d)",
                        rule,((rule->actionset != NULL)&&((rule->actionset->id != NULL)&&
                                (rule->actionset->id != NOT_SET_P))) ? rule->actionset->id : "-",
                        rule->filename != NULL ? rule->filename : "-",
                        rule->line_num,rc);

Let me know if it fix the issue

from modsecurity.

PCRE Version: PCRE 8.32

OS:

• Solaris 10 Sparc gcc 4.7.2
• SuSE SLES 11 x86_64 platform gcc
• REHL 6 x86_64 platform gcc

all with custom build Apache

Of course it only happens with "--enable-pcre-jit".

Full configure line:

./configure
--without-curl
--with-apxs=/path/to/my/apache/bin/apxs
--with-apr=/path/to/my/apache/bin/apr-1-config
--with-apu=/path/to/my/apache/bin/apu-1-config
--with-libxml=/path/to/my/libxml2
--with-lua=/path/to/my/lua
--with-pcre=/path/to/my/pcre
--enable-pcre-jit
--disable-mlogc

Will test your suggested patch and report back.

from modsecurity.

Yes, your patch fixes the test failures for me on all platforms.

Note that the same test against NULL but not against NOT_SET_P happens in 9 places in re_operators.c. Not sure whether the test against NOT_SET_P is needed in all those places.

Some similar checks occur in re.c. The file apache2_config.c seems OK to me.

from modsecurity.

Fixed

from modsecurity.