Logs not showing inside GKE about pino-stackdriver HOT 3 CLOSED

I did some digging:

https://github.com/googleapis/nodejs-logging/blob/6f01c6679d7b4689ceb03011f37e4def5d9025f4/src/log.ts#L822

It looks like @google-cloud/logging by itself fetches the right labels if non are provided. But pino-stackdriver set's a default:

  const entry = {
    meta: {
      resource: resource || { type: 'global' },
      severity
    },
    data
  }

found here:

Should this module default to { type: 'global' } or leave it to @google-cloud/logging? I am happy to create a PR

from pino-stackdriver.

Is that only an issue you have with the resource.labels? Because if you do not provide anything to the module, it defaults to a resource of { type: 'global' }. But in that case resource.labels is still undefined. It only sets type.

from pino-stackdriver.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from pino-stackdriver.