Git Product home page Git Product logo

Comments (3)

speed47 avatar speed47 commented on June 22, 2024 1

Nice catch, you're right key is a reserved prefix, I'll add a pre-check to groupCreate to ensure such group can't be created.
As you probably saw, all the bastion group names (actually, bastion group roles) are mapped to OS groups, using the "key" prefix (and some suffixes for the roles).

Removing this constraint can be done, but it needs thorough testing, to ensure there's no confusion between "a bastion group name" and "a system group mapped to a bastion group" anywhere in the code. So I'll start by just denying the creation of such groups, and lifting this limitation only when I'm sure there are no longer any side effect of prepending a group name with key.

from the-bastion.

jonathanmarsaud avatar jonathanmarsaud commented on June 22, 2024

It seems that it's tied to this as a reserved keyword key for groupName (and accountName it seems).
We'll consider to rename our group so, but maybe a warning should come up when such a group with reserved prefix is created

Moreover, in your regex /^key/, what happen if somebody creates a keykeylogy group?

Thanks anyway.

Edit: Missed copy/paste.

from the-bastion.

speed47 avatar speed47 commented on June 22, 2024

Closing this issue, and opening another one (without the "bug" tag) for the future feature of supporting groups names starting with "key"

from the-bastion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.