Git Product home page Git Product logo

Comments (3)

regisb avatar regisb commented on August 17, 2024 1

Maybe "orderhistory" is overly precise and we could go with simply "orders"?

from tutor-ecommerce.

regisb avatar regisb commented on August 17, 2024

hmmmm good catch. Yes, this is a bug.

The problem with your suggested solution is that it will cause the ecommerce MFE to be served from http://appsyourlms.com/ecommercemfe -- which is not great. I mean: I like your solution, but I think we should try to find a different name. The ecommerce MFE is itself not very well named; after all the only thing it does is to display the user order history. So, could we simply use "name": "orderhistory"?

from tutor-ecommerce.

BbrSofiane avatar BbrSofiane commented on August 17, 2024

True I didn't think about the URL.

I thought about calling it orderhistory but it means that if there is more functionality added to it we might have to change the name. I'm making the assumption that since edX called the repo frontend-app-ecommerce they might add functionality beyond order history.

But I think for now orderhistory sounds good!

from tutor-ecommerce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.