Failing to scan repository with FossID: Cannot deserialize value of type `java.util.LinkedHashMap<java.lang.String,java.lang.String>` about ort HOT 8 OPEN

@sschuberth Could you maybe assign the issue to me ?

from ort.

@nnobelis could you please look into this?

from ort.

@alexandruz any insights what might have changed in FOSSID'S data model?

from ort.

@realbigflo Unfortunately, we cannot log the requests to FossID as they contain credentials.

We are also running this version and we don't get the the error.
Looking at your stack trace it seems FossID returns now for service.createScan an array and not a map anymore, but ORT should be able to handle this case.

If you want, reach me internally and we can look at this problem together.

from ort.

While debugging with @nnobelis we figured out, the problem is caused by an access problem of Fossid for the specific git repository. I thought initially, that the ssh key was added correctly to the bitbucket instance but unfortunately this wasn't the case.

This is the request that should be send to the FossID instance:

curl --header "Content-Type: application/json" --request POST --data "{\"action\":\"create\",\"group\":\"scans\",\"data\":{\"username\":\"username\",\"key\":\"mykey\",\"project_code\":\"test_project\",\"scan_code\":\"test_ssh_cred_fail\",\"scan_name\":\"test_ssh_cred_fail\",\"git_repo_url\":\"ssh git repo url\",\"git_branch\":\"develop\"}}" <fossid REST endpoint>

{"operation":"scans_create",
 "status":"0",
 "data":[{"code": "RequestData.Base.issue_with_executing_command",
              "message":"Field git_repo_url: there was an issue executing command: timeout 200 git ls-remote 'ssh git repo' 2>&1. Exit status: 128. Output: Repository not found The requested repository does not exist, or you do not have permission to access it. fatal: Could not read from remote repository.  Please make sure you have the correct access rights and the repository exists.",
              "message_parameters":{"fieldname":"git_repo_url",
                                                    "cmd":"timeout 200 git ls-remote 'ssh git repo' 2>&1",
                                                    "exitStatus":128,
                                                    "out":"Repository not found The requested repository does not exist, or you do not have permission to access it. fatal: Could not read from remote repository.  Please make sure you have the correct access rights and the repository exists."}
              }],
"error":"RequestData.Base.issues_while_parsing_request",
"message":"These issues were found while parsing the request:",
"message_parameters":[]
}

After correcting the authentication issue, the result of the request looks like:

{"operation":"scans_create",
 "status":"1",
 "data":{"scan_id":23732},
 "message":"Scan test_ssh_cred_fail has been created."
  }

The data field in the failure case is an array with a single element (map) while in the good case, it is only a map.

from ort.

Thanks a lot @realbigflo : Yeah, it seems they changed the syntax of the error response, with even more polymorphism :(
I will have a look.

from ort.

@sschuberth I started to work on it here: #8541

Unfortunately, the exception is still present: the polymorphic deserializer currently allows to process multiple responses for the same function: T, [T], { "xxx", T }.

Unfortunately, in this case, the responses are either data: { "scan_id": N } or something totally different e.g.

"data":[{"code": "RequestData.Base.issue_with_executing_command",
              "message":"Field git_repo_url: there was an issue executing command: timeout 200 git ls-remote 'ssh git repo' 2>&1. Exit status: 128. Output: Repository not found The requested repository does not exist, or you do not have permission to access it. fatal: Could not read from remote repository.  Please make sure you have the correct access rights and the repository exists.",
              "message_parameters":{"fieldname":"git_repo_url",
                                                    "cmd":"timeout 200 git ls-remote 'ssh git repo' 2>&1",
                                                    "exitStatus":128,
                                                    "out":"Repository not found The requested repository does not exist, or you do not have permission to access it. fatal: Could not read from remote repository.  Please make sure you have the correct access rights and the repository exists."}
              }],

I still need to work this out.

from ort.

As I don't see how to fix this without an ugly hack, I asked our OPS to create a ticket at FossID support.

from ort.