Comments (9)
Yeah, but my point is that the hyperlink doesn't have to be algorithmically generated. It's an absolute link that's added as the metadata, it doesn't need to be generate-able from other metadata. It could even be to a file hosted somewhere other github
from assetlists.
All images have been added to the chain registry in this PR.
from assetlists.
It would be more coherent but I see some issue :
- Which tree would it be, because everything is in /images in our repo, but on chain-registry the tree is /project/images ? How to know the name of the project, we have only the symbol
- Not everyone uses the same images, some are not even official, there is no predefined standard, for Osmosis we prefer rounded images for example
from assetlists.
Yeah, it would be in project/images
And we don't need to know the name of the project, cause all we need is a direct hyperlink to the image files
Yeah, basically for inclusion into this repo, we're requiring coin logos to be circles or circle-ish. We can just do the same over on cosmos/chain-registry. (for context, at the moment, I'm basically maintaining that repo, so I can just enforce the same rules there).
from assetlists.
- Current direct hyperlink is for example : https://raw.githubusercontent.com/osmosis-labs/assetlists/main/images/atom.png
If switch underproject/images
it's would be : https://raw.githubusercontent.com/osmosis-labs/assetlists/main/cosmoshub/images/atom.png
The project namecosmoshub
is not referenced anywhere as far as I know. - Oh great, sound good for me then if you maintaining the repo
from assetlists.
I understand better, indeed let's do this, I make the PR with the logos, and we migrate the logos on chain-registry.
from assetlists.
I believe at this point, all the images exist on Chain Reg, and the logo URIs in each asset object in the assetlist are also pointing to the Chain Reg, but I believe the Info site still hardcodes the local png and the image. Can we change this to be algorithmically generated from the Chain Reg so we don't need to store duplicate images in this repo?
from assetlists.
If we want images to be in a registry, the URLs should point to a CDN somewhere vs github.
If we don't put images in a CDN as we do now with frontend images via Vercel, users may experience a less performant UX with all of the icons, token icons, bg images, etc.
from assetlists.
CDN is a good idea, although I'd say the primary issue has been resolved.
from assetlists.
Related Issues (20)
- Issues with incentives gauge appearing on the frontend since days HOT 4
- konstellation coingecko_id is incorrect
- Move USTC and LUNC to frontier only
- Rename "osmo-channel"
- Change symbol for bridge assets to use suffix form HOT 2
- Please, be aware: Echelon chain/project is scam HOT 3
- Invalid "display" field for tgrade token
- Make CI check correctness of all IBC denoms HOT 1
- MKR token logo broken HOT 1
- Keep Assetlist Schema in Sync with Chain Registry HOT 3
- Support Chain Infos in this Repo? HOT 1
- osmo1e3dcl9jk2wclslyk93ak8726mhwdhps8fhvfwg HOT 1
- Generating the assetlist.json file HOT 3
- Script to generate go types HOT 2
- Sequence diagram of CI/CD interaction and assetlist generation with the chain-registry
- Verify assets that got unverified during frontend asset list integration HOT 3
- Integration of CW20 token on assetlist HOT 5
- Support optional `synonyms` member to objects in `assets` HOT 3
- $baddog not appearing in osmosis frontend HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from assetlists.