Git Product home page Git Product logo

Comments (9)

sunnya97 avatar sunnya97 commented on August 20, 2024 1

Yeah, but my point is that the hyperlink doesn't have to be algorithmically generated. It's an absolute link that's added as the metadata, it doesn't need to be generate-able from other metadata. It could even be to a file hosted somewhere other github

from assetlists.

JeremyParish69 avatar JeremyParish69 commented on August 20, 2024 1

All images have been added to the chain registry in this PR.

from assetlists.

IbrarMakaveli avatar IbrarMakaveli commented on August 20, 2024

It would be more coherent but I see some issue :

  • Which tree would it be, because everything is in /images in our repo, but on chain-registry the tree is /project/images ? How to know the name of the project, we have only the symbol
  • Not everyone uses the same images, some are not even official, there is no predefined standard, for Osmosis we prefer rounded images for example

from assetlists.

sunnya97 avatar sunnya97 commented on August 20, 2024

Yeah, it would be in project/images

And we don't need to know the name of the project, cause all we need is a direct hyperlink to the image files

Yeah, basically for inclusion into this repo, we're requiring coin logos to be circles or circle-ish. We can just do the same over on cosmos/chain-registry. (for context, at the moment, I'm basically maintaining that repo, so I can just enforce the same rules there).

from assetlists.

IbrarMakaveli avatar IbrarMakaveli commented on August 20, 2024

from assetlists.

IbrarMakaveli avatar IbrarMakaveli commented on August 20, 2024

I understand better, indeed let's do this, I make the PR with the logos, and we migrate the logos on chain-registry.

from assetlists.

JeremyParish69 avatar JeremyParish69 commented on August 20, 2024

I believe at this point, all the images exist on Chain Reg, and the logo URIs in each asset object in the assetlist are also pointing to the Chain Reg, but I believe the Info site still hardcodes the local png and the image. Can we change this to be algorithmically generated from the Chain Reg so we don't need to store duplicate images in this repo?

from assetlists.

jonator avatar jonator commented on August 20, 2024

If we want images to be in a registry, the URLs should point to a CDN somewhere vs github.

If we don't put images in a CDN as we do now with frontend images via Vercel, users may experience a less performant UX with all of the icons, token icons, bg images, etc.

from assetlists.

JeremyParish69 avatar JeremyParish69 commented on August 20, 2024

CDN is a good idea, although I'd say the primary issue has been resolved.

from assetlists.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.