osm2pgsql granting select on output tables to PUBLIC about osm2pgsql HOT 7 CLOSED

The culprit is here: https://github.com/openstreetmap/osm2pgsql/blob/master/output-pgsql.c#L1133

from osm2pgsql.

Our workaround: CartoDB/cartodb@a1660aa

from osm2pgsql.

The rational is to make importing as easy as possible and not require X steps to be performed on the db after osm2pgsql is finished before one has a workable database.

However, this behaviour should probably be configurable and be able to be turned off with an extra command line parameter if these assumptions aren't correct.

from osm2pgsql.

+1 on the possibility to turn off with extra command line parameter

from osm2pgsql.

While I understand the rational, I don't agree with it in this case. It's reasonable to expect that the data is accessible only to the user that ran the import, unless further steps are taken. Having the built-in step to grant read permissions to all users is unexpected - I wouldn't even expect that in the install / usage guide, never mind built in to the tool.

I would prefer to remove this behaviour from the code entirely, and add notes to the documentation if the need for the public-permission-granting is common.

from osm2pgsql.

@lonvia we should decide on this. The patch is pretty trivial technically. I agree with @gravitystorm on this, it's not expected behavior.

from osm2pgsql.

+1 for removing the grant. It's surprising.

from osm2pgsql.