Git Product home page Git Product logo

Comments (8)

bjhargrave avatar bjhargrave commented on June 12, 2024 2

failing to build in CI with Java 8 because Gradle uses a version of Logback that requires Java 11

Gradle does not use this. It is used by the example. I reverted #760 and we will need to tell dependabot to only use logback 1.3.x for the examples.

from osgi-test.

timothyjward avatar timothyjward commented on June 12, 2024 1

Since it is just examples.. is would go 21

We had previously been using a build matrix to prove that we remained compatible with all of the target java versions for osgi-test, which still has a base of Java 8. I would have expected that we might drop 8 from the matrix but keep 11, 17 and 21.

from osgi-test.

timothyjward avatar timothyjward commented on June 12, 2024

@rotty3000 @stbischof @bjhargrave @kriegfrj

Thoughts?

from osgi-test.

stbischof avatar stbischof commented on June 12, 2024

Since it is just examples.. is would go 21

from osgi-test.

stbischof avatar stbischof commented on June 12, 2024

and maybe LASTEST

from osgi-test.

bjhargrave avatar bjhargrave commented on June 12, 2024

You can build with Java 17 (or 21) and still target Java 8. So I don't see any real reason to move the examples from their current state.

I am not sure why you would drop Java 8 support. Bnd did because we wanted to exploit changes in the language in the large code base that is Bnd and Bnd is mostly a tool and not a runtime. I don't think osgi-test would really benefit like that and it would break downstream users who still require Java 8 as their runtime (and there are still many of those).

from osgi-test.

timothyjward avatar timothyjward commented on June 12, 2024

I am not sure why you would drop Java 8 support.

The gradle example builds are currently failing to build in CI with Java 8 because Gradle uses a version of Logback that requires Java 11. I'm not proposing to drop Java 8 for osgi-test, but at the moment all PRs have a failing check.

from osgi-test.

bjhargrave avatar bjhargrave commented on June 12, 2024

Looking at the failed build, the issue is with a Logback update to 1.4 which no longer supports Java 8. Perhaps the answer is to revert #760 and then tell dependabot to ignore logback 1.4 when it next proposes to update to 1.4.

from osgi-test.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.