Android always gives unknown color error when fallback color is #000 about react-native-image-colors HOT 6 CLOSED

Okay, I will create PR on days

from react-native-image-colors.

@KrzysztofMoch Yeah my minimal suggestion here is that the error message is improved. Instead of:

Error: Unknown color

It should be:

Error: Unknown fallback color. Do not use shorthand hex e.g. #fff.

This will make debugging easier for future developers. If you can support shorthand that would be even better but not necessarily needed.

Edit: I thought the error was saying it could not detect the color of the image but it was related to the fallback color which took me awhile to realize.

from react-native-image-colors.

@KrzysztofMoch I update the bug report. This only happens when the fallback color is set to #000. On iOS this works but on Android this throws an error. See my description for further details.

To answer your question, it happens for all pictures when given the fallback #000. I fixed it when I gave the fallback #000000. For Android you must give a full hex code otherwise this error is thrown.

from react-native-image-colors.

Yes In docs for fallback collor

fallback collor: If a color property couldn't be retrieved, it will default to this hex color string (note: do not use shorthand hex. e.g. #fff).

You must to use 6 characters (e.g #000000)

from react-native-image-colors.

@osamaqarem should we add support for 3 chars colros on android ?

from react-native-image-colors.

@osamaqarem should we add support for 3 chars colros on android ?

If you would like to go for it, that would be nice 👍

Otherwise the report makes a good point, it would be easy for us to detect the length of the fallback string and throw a friendly error.

from react-native-image-colors.