Allow for easily matching rules using path prefixes about oathkeeper HOT 7 OPEN

/cc @aeneasr since you asked for a more thorough explanation and/or design document for my PR.

from oathkeeper.

Friendly ping @aeneasr .

from oathkeeper.

Friendly ping @zepatrik maybe you can also chime in here.

from oathkeeper.

This looks pretty nice! Would it make sense to re-use the matching logic of httprouter? I think they solved this already, basically, and it's really fast!

from oathkeeper.

I haven’t looked into httprouter so I’d need to have a look at it.

from oathkeeper.

It looks like httprouter is doing the same thing, except it seems to be a bit more advanced in terms of matching. What is the same though is that wildcard matching (or in our case regex and glob) can only be done at the end of a URL. Another similarity is that they also seem to be adding the method into the Trie.

One big difference though is that they don’t insert the host name into the Trie. Rather, you’d need to create a new router (and therefore a new Trie) for each domain.

I’d need to look into the code a bit closer to see if there’s pieces we could use as a module or if they can otherwise be adapted into this codebase. Since it doesn’t look like that project is super active and that the Trie structure we’d use is like a bit different I’m leaning towards the latter.

from oathkeeper.

After looking at the code it seems very similar to what I’ve already implemented, and I don’t think we’d be able to reuse it as is. However, it probably does have some useful bit that can be used to improve the code I’ve already written.

So @aeneasr, my question now is how can we best try to move this forward?

from oathkeeper.