Do not publish ports on Linux about dockertest HOT 10 CLOSED

I am closing this issue as it has not received any engagement from the community or maintainers in a long time. That does not imply that the issue has no merit. If you feel strongly about this issue

• open a PR referencing and resolving the issue;
• leave a comment on it and discuss ideas how you could contribute towards resolving it;
• open a new issue with updated details and a plan on resolving the issue.

We are cleaning up issues every now and then, primarily to keep the 4000+ issues in our backlog in check and to prevent maintainer burnout. Burnout in open source maintainership is a widespread and serious issue. It can lead to severe personal and health issues as well as enabling catastrophic attack vectors.

Thank you to anyone who participated in the issue! 🙏✌️

from dockertest.

This is solved

from dockertest.

I'm not sure it is. #126 only adds a method to retrieve a host:port pair, but the library still publishes all ports and returns a mapped host:port pair (localhost:31234 instead of 172.17.0.2:3306).

from dockertest.

Oh, whoops :)

from dockertest.

Hm, not publishing those ports would break older versions - how about a flag that tells dockertest explicitly to not publish the ports if on linux?

from dockertest.

You mean a global or a flag in RunOptions? Either way, it will solve the compatibility issue.

from dockertest.

I think a global config (maybe at pool creation?) makes the most sense

from dockertest.

Sounds good! I'll work on it when I get some time.

from dockertest.

Awesome!

from dockertest.

Well, if anyone else searched through the Internet like me, here is the solution:

resource, err := pool.RunWithOptions(&dockertest.RunOptions{
	Repository: "foo", Tag: "bar",
}, func(m *dc.HostConfig) {
	m.PublishAllPorts = false
	m.Memory = 2 * consts.GB
})
ip := resource.Container.NetworkSettings.IPAddress

Should PublishAllPorts be exposed to RunOptions? Not sure.

from dockertest.