Git Product home page Git Product logo

Comments (4)

messenjer avatar messenjer commented on June 11, 2024 1

I try to upgrade to 1.0 from my PR #101, here is the first commit : messenjer@5c0a90f

There are sass variables from bulma 0.9 used in theme-bulma that have been renamed, or calculated differently in bulma 1.0.

Example :

  • $input-background-color --> hsl( $input-h, $input-s, calc(input-background-l + input-background-l-delta))

Here: https://github.com/jgthms/bulma/blob/d2687d444c907893a6feb8733404364b871a94d5/sass/form/shared.scss#L97

  background-color: hsl(
    #{cv.getVar("input-h")},
    #{cv.getVar("input-s")},
    calc(
      #{cv.getVar("input-background-l")} + #{cv.getVar(
          "input-background-l-delta"
        )}
    )
  );

So for this color, I created a temporary file https://github.com/messenjer/theme-bulma/blob/7c1ac51fbc7c71e8f2e4e96390927b15ae83c6e7/src/assets/scss/components/utils/_variables-to-migrate.scss

@use "bulma/sass" as bulma;
@use "bulma/sass/utilities" as fn;

$primary-invert: bulma.$white !default;
$dropdown-item-hover-background-color: bulma.$dropdown-item-background-l !default;
$dropdown-item-hover-color: bulma.$dropdown-item-color-l !default;
$input-focus-box-shadow-size: bulma.$input-focus-shadow-size !default;
$input-focus-box-shadow-color: bulma.$input-focus-l !default;

We can improve the oruga theme using the new mixins, functions from bulma v1, perhaps we should ask for advice on the bulma project to get recommendations and help.

from theme-bulma.

lucraraujo avatar lucraraujo commented on June 11, 2024

According to the release notes, V1 should be a drop-in replacement for 0.9.4.

from theme-bulma.

messenjer avatar messenjer commented on June 11, 2024

Hello,

For one of my projects, I had the necessity to customize the entire Oruga Bulma theme using CSS variables. Consequently, instead of utilising Oruga's theme-bulma, I opted for the Bulvar library available at https://github.com/daniil4udo/bulvar for the Buefy project. However, if the Oruga theme-bulma upgrade to the latest version of Bulma (version 1) with built-in support for CSS variables, it would eliminate the need for Bulvar.

To upgrade to bulma v1 we need also to replace all the @import by @use or @forward and setup correctly the variables inside the theme-bulma. There is an old pull request here: #49 by @IceBlizz6 . It might help to port this PR to the master branch.

Mathieu

from theme-bulma.

messenjer avatar messenjer commented on June 11, 2024

I created a PR to replace @import with @use, @forward #101 a step towards bulma v1

from theme-bulma.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.