Equation used in `is_patch_inside_FOV` function about retina-unet HOT 4 CLOSED

Considering patch_h as the height of a patch in pixels, for a patch to be fully inside the FOV we consider the worst case scenario where a patch intersects the circle of the FOV (of radius 270) along the diagonal.

But you're right, we're being too conservative: we should be using half the diagonal since we're limiting the position of the center of the patch with respect to the center of the image. The correct equation should be R_inside = 270 - int(patch_h / np.sqrt(2) * 2).

/cc @dcorti

from retina-unet.

@lantiga R_inside = 270 - int(patch_h / np.sqrt(2) * 2) is the same equation as used in the code. The correct equation, according to me, should be R_inside = 270 - int(patch_h * np.sqrt(2) / 2)

from retina-unet.

Hi,

You're right, only half diagonal should be considered and not the full one. Your equation is correct, I updated the code. Thank you for spotting the mistake!

from retina-unet.

Hey, so: I messed up. @amitmanchanda1995, of course you're right. I apologize for the noise.

from retina-unet.