Git Product home page Git Product logo

Comments (7)

wanderingstan avatar wanderingstan commented on September 27, 2024

Minor comment: We should consider a more descriptive name for BUYER_PENDING. Coming back to this after a week a way I can't remember what this means. E.g. are we waiting for a buyer at all? Are we waiting for the buyer to pay?

from origin-js.

DanielVF avatar DanielVF commented on September 27, 2024

I also would like a more descriptive name. We are waiting on the buyer to mark the purchase received.

Got any suggestions?

from origin-js.

micahalcorn avatar micahalcorn commented on September 27, 2024

I like the awaiting_{event} convention, which might be implied by AWAITING_PAYMENT. This issue makes me realize that design and engineering may not be entirely on the same page regarding the steps involved in a transaction.

At the risk of this being the wrong place for this...

In the current UI, there are six events that affect transaction state, each caused by the action of a sole party, and two of them (5 & 6) being potentionally out of sequence:

  1. Create listing (seller)
  2. Buy listing (buyer) - presumed to be the equivalent of sending money
  3. Fulfill order (seller)
  4. Receive order (buyer)
  5. Withdraw funds (seller)
  6. Provide feedback (buyer)

We don't currently handle disputes as a potential part of the flow, and the seller's feedback (applicable to the buyer) is not currently handled. The current philosophy is that there is a distinction between the contexts of a buyer's review and a seller's review. The buyer is reviewing the listing - not reviewing the seller. And the seller is reviewing the buyer - not the purchase or some other instance.

from origin-js.

DanielVF avatar DanielVF commented on September 27, 2024

So in the long term I'd have the buyer receive the order and give a review at the same time, then the seller would give a review and withdraw simultaneously.

--

The reviews for both buyer and seller would be attached to the Purchase. The bridge server would then index those and combine them for seller information on the listing and for information on a user.

from origin-js.

micahalcorn avatar micahalcorn commented on September 27, 2024

@DanielVF that makes sense if review/feedback is required. That would beg the question what constitutes a valid review. 😬

from origin-js.

DanielVF avatar DanielVF commented on September 27, 2024

Well, the reviews are optional - we're just including them in with the steps that the buyer and seller are already doing. As a first pass, I was thinking 1-5 star and optional text.

from origin-js.

micahalcorn avatar micahalcorn commented on September 27, 2024

Since we don't currently plan to use a reasonably short buyer timeout, we will skip this for now.

from origin-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.