Comments (7)
Hmm, I sorta mean something like unit tests, where it tries to isolate some parts of the code and make sure the logic is fine, I forgot that you had automatic testing already set in-place [...]
A fair amount of code is being tested but it can always be extended. Maybe some features are not tested against all the combined cases. I should work on that more, for sure.
[...] about the other errors, I more was reporting the fact that they weren't handled, and were just "raw" Rust errors.
I see. I should eliminate the use of .expect("Failed to ...")
on some common places.
from menyoki.
Ah, right! I'm so sorry! I forgot that I kept this open... Thank you for the reminder!
from menyoki.
Umm... I remember having a third problem about it but I think I've just forgotten about it... I'll try my best to remember it haha
from menyoki.
Oh, I remember, it was a general thing: Why not add automatic testing to test the features you'll be adding onto your project, to minimise bugs and unexpected behvaiour?
from menyoki.
1. Pairing it with the `root` flag seems to take the screenshot immediately, not listening to my mouse input, but it does capture transparency, so that's nice. It also seems to work fine when I try to delay the screenshot and go to a workspace without a desktop, unlike the following point.
--root
and --focus
flags doesn't set the --select
implicitly so you have to specify them as well if you want to select a window.
--select Select the window to capture
I'm not sure how this is related to transparency. It'd be nice if you can try something like menyoki rec --root --select -m
and post results while I'm investigating this further.
2. Pairing it with the `parent` flag seems to work relatively as expected, it just doesn't show the overlay that it does by default, and it seems to error with:
When I ran the command, switched to a different workspace that had no windows, and clicked on the wallpaper/desktop.
menyoki tries to capture the parent of the selected window (if any) if --parent
flag is provided. It also tries to draw the borders on that window so it might be expected for them to not seen in some cases. It was a feature that I added for window managers that put their content not on the actual window, but the parent. (#6)
The error you got was probably about the use of this flag or the fact that --mouse
doesn't actually check if there's a window on the clicked area. (Like I said, it was a very basic implementation.) Because it seems like it couldn't get the image
, which means in a sense it might not find any window to capture.
Oh, I remember, it was a general thing: Why not add automatic testing to test the features you'll be adding onto your project, to minimise bugs and unexpected behvaiour?
What exactly do you mean by "automatic testing"? Anything other than this?
from menyoki.
Hmm, I sorta mean something like unit tests, where it tries to isolate some parts of the code and make sure the logic is fine, I forgot that you had automatic testing already set in-place haha, about the other errors, I more was reporting the fact that they weren't handled, and were just "raw" Rust errors.
from menyoki.
Is this issue resolved? Did you have the chance to try it again?
from menyoki.
Related Issues (20)
- RUSTSEC-2020-0071: Potential segfault in the time crate
- RUSTSEC-2022-0013: Regexes with large repetitions on empty sub-expressions take a very long time to parse HOT 1
- RUSTSEC-2022-0006: Data race in `Iter` and `IterMut` HOT 1
- RUSTSEC-2020-0163: `term_size` is unmaintained; use `terminal_size` instead
- RUSTSEC-2021-0139: ansi_term is Unmaintained HOT 2
- webp recording throwing an error HOT 1
- Support recording WebP
- Support pause during recording
- Expand shell expressions for files HOT 2
- Recording the mouse pointer HOT 1
- Adaptive framerate
- Support recording WebM
- Include a way to select a capture zone with the cursor
- CLI is awkward to use HOT 1
- Support lodepng for encoding PNGs
- The duration argument (-d <S>) doesn't seem to work HOT 5
- Cancelling action should produce exit status HOT 5
- Ctrl+c does not work to stop during the saving of the gif. HOT 2
- Stop recording throw an error and does not generate any gif HOT 3
- Improve the key bindings documentation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from menyoki.