Comments (12)
I'll try it out and let you know if I face any issues. And thank you for the excellent software!
from menyoki.
Cool. I've opened #16 to discuss this further
from menyoki.
Hey,
You'll be able to specify the screen monitor via --monitor <NUM>
argument for record/capture actions with the upcoming release. (Handled via RandR extension).
You can build menyoki from source and test it out if you don't want to wait for the next release. In fact, that'd be great for spotting the bugs in advance if there's any :)
Thanks for the submission!
from menyoki.
The feature is working fine as documented. One small issue, not sure if its related or not. When I capture the root window with menyoki capture --root
(along with any other parameters, such as --select
or --select --monitor 1
), the green border showing the selection area does not show up anymore. The correct dimensions are shown on the terminal, and the capture also works properly, its just the outline that is not visible. The border appears when capturing a non-root window.
I ran the test suite, and noticed that two tests are failing on my system. The full results are below. I use two monitors in a side-by-side configuration, one is 1920x1080 and the other is 1366x768.
running 36 tests
test analyze::settings::tests::test_time_zone ... ok
test anim::decoder::tests::test_anim_decoder ... ok
test analyze::settings::tests::test_analyze_settings ... ok
test anim::tests::test_anim_mode ... ok
test anim::settings::tests::test_split_settings ... ok
test args::parser::tests::test_parser ... ok
test apng::tests::test_apng_encoder ... ok
test args::matches::tests::test_matches ... ok
test edit::settings::tests::test_edit_settings ... ok
test analyze::tests::test_analyze ... ok
test gif::encoder::tests::test_gif_encoder ... ok
test anim::settings::tests::test_anim_settings ... ok
test image::geometry::tests::test_geometry ... ok
test image::padding::tests::test_padding ... ok
test file::settings::tests::test_save_settings ... ok
test image::settings::tests::test_jpg_settings ... ok
test image::settings::tests::test_png_settings ... ok
test file::tests::test_file ... ok
test image::tests::test_image ... ok
test record::settings::tests::test_record_settings ... ok
test args::tests::test_shell_completions ... ok
test app::tests::test_app_image ... ok
test settings::tests::test_app_settings ... ok
test image::settings::tests::test_pnm_settings ... ok
test gif::encoder::tests::test_gifski_encoder ... ok
test util::logger::tests::test_logger ... ok
test util::state::tests::test_input_state ... ok
test util::keys::tests::test_action_keys ... ok
test util::command::tests::test_command ... ok
test record::fps::tests::test_fps ... ok
test edit::tests::test_edit ... ok
test app::tests::test_app_anim ... ok
test record::tests::test_record ... ok
test x11::display::tests::test_x11_display ... ok
test x11::window::tests::test_x11_window ... FAILED
test x11::tests::test_x11_system ... FAILED
failures:
---- x11::window::tests::test_x11_window stdout ----
thread 'x11::window::tests::test_x11_window' panicked at 'assertion failed: (left == right)
Diff < left / right > :
Geometry {
< x: 0,
x: 1366,
y: 0,
< width: 1366,
< height: 768,
width: 1920,
height: 1080,
}
', src/x11/window.rs:492:9
note: run with RUST_BACKTRACE=1
environment variable to display a backtrace
---- x11::tests::test_x11_system stdout ----
thread 'x11::tests::test_x11_system' panicked at 'assertion failed: (left == right)
Diff < left / right > :
<3147264
10646640
', src/x11/mod.rs:149:9
failures:
x11::tests::test_x11_system
x11::window::tests::test_x11_window
test result: FAILED. 34 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 4.70s
error: test failed, to rerun pass '--bin menyoki'
from menyoki.
Hmm, that's unexpected. Can you increase the border width (e.g. --border 10
) and see if shows up?
Failing tests are expected though. I used hardcoded values for the window dimensions. (They are meant to be run with xvfb
, e.g. xvfb-run --server-args="-screen 0 1366x768x24" cargo test --features test-ws
)
from menyoki.
Okay, the tests work with xvfb-run
. But setting border width to 10 did not change anything, still shows the right thing on terminal but no border on screen
from menyoki.
Huh. That's odd. I was sure that it was working correctly with the released version (1.1.0), but checking now it seems to not show up even on that version
from menyoki.
That's weird. Did restarting X11 help?
from menyoki.
Nope. Just tried that too
from menyoki.
I'm trying to reproduce the issue and realized that borders are not visible at the start but they become visible when I move/resize them on my 1920x1080 monitor. Everything's fine on my other monitor. Maybe it's trying to draw them outside the screen boundaries. Can you confirm that if that's your issue or not?
Edit: It's showing the area size on the center of the screen as expected, right?
from menyoki.
Yes, the area size is seen correctly. However, the borders are definitely not seen at all. I verified this by doing menyoki capture --root --select --size $(slop)
, and selected a region in the middle of my screen. No borders show up
from menyoki.
It looks like it's time that I investigate this problem in a separate issue. Can you create a new issue where you provide the information about your system (OS, WM, X version, logs etc.) after closing this one?
from menyoki.
Related Issues (20)
- RUSTSEC-2020-0071: Potential segfault in the time crate
- RUSTSEC-2022-0013: Regexes with large repetitions on empty sub-expressions take a very long time to parse HOT 1
- RUSTSEC-2022-0006: Data race in `Iter` and `IterMut` HOT 1
- RUSTSEC-2020-0163: `term_size` is unmaintained; use `terminal_size` instead
- RUSTSEC-2021-0139: ansi_term is Unmaintained HOT 2
- webp recording throwing an error HOT 1
- Support recording WebP
- Support pause during recording
- Expand shell expressions for files HOT 2
- Recording the mouse pointer HOT 1
- Adaptive framerate
- Support recording WebM
- Include a way to select a capture zone with the cursor
- CLI is awkward to use HOT 1
- Support lodepng for encoding PNGs
- The duration argument (-d <S>) doesn't seem to work HOT 5
- Cancelling action should produce exit status HOT 5
- Ctrl+c does not work to stop during the saving of the gif. HOT 2
- Stop recording throw an error and does not generate any gif HOT 3
- Improve the key bindings documentation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from menyoki.