Git Product home page Git Product logo

Comments (12)

anihm136 avatar anihm136 commented on August 23, 2024 1

I'll try it out and let you know if I face any issues. And thank you for the excellent software!

from menyoki.

anihm136 avatar anihm136 commented on August 23, 2024 1

Cool. I've opened #16 to discuss this further

from menyoki.

orhun avatar orhun commented on August 23, 2024

Hey,
You'll be able to specify the screen monitor via --monitor <NUM> argument for record/capture actions with the upcoming release. (Handled via RandR extension).

You can build menyoki from source and test it out if you don't want to wait for the next release. In fact, that'd be great for spotting the bugs in advance if there's any :)

Thanks for the submission!

from menyoki.

anihm136 avatar anihm136 commented on August 23, 2024

The feature is working fine as documented. One small issue, not sure if its related or not. When I capture the root window with menyoki capture --root (along with any other parameters, such as --select or --select --monitor 1), the green border showing the selection area does not show up anymore. The correct dimensions are shown on the terminal, and the capture also works properly, its just the outline that is not visible. The border appears when capturing a non-root window.
I ran the test suite, and noticed that two tests are failing on my system. The full results are below. I use two monitors in a side-by-side configuration, one is 1920x1080 and the other is 1366x768.

➜ cargo test --features test-ws Finished test [optimized + debuginfo] target(s) in 0.06s Running target/debug/deps/menyoki-b35f562e2f18c344

running 36 tests
test analyze::settings::tests::test_time_zone ... ok
test anim::decoder::tests::test_anim_decoder ... ok
test analyze::settings::tests::test_analyze_settings ... ok
test anim::tests::test_anim_mode ... ok
test anim::settings::tests::test_split_settings ... ok
test args::parser::tests::test_parser ... ok
test apng::tests::test_apng_encoder ... ok
test args::matches::tests::test_matches ... ok
test edit::settings::tests::test_edit_settings ... ok
test analyze::tests::test_analyze ... ok
test gif::encoder::tests::test_gif_encoder ... ok
test anim::settings::tests::test_anim_settings ... ok
test image::geometry::tests::test_geometry ... ok
test image::padding::tests::test_padding ... ok
test file::settings::tests::test_save_settings ... ok
test image::settings::tests::test_jpg_settings ... ok
test image::settings::tests::test_png_settings ... ok
test file::tests::test_file ... ok
test image::tests::test_image ... ok
test record::settings::tests::test_record_settings ... ok
test args::tests::test_shell_completions ... ok
test app::tests::test_app_image ... ok
test settings::tests::test_app_settings ... ok
test image::settings::tests::test_pnm_settings ... ok
test gif::encoder::tests::test_gifski_encoder ... ok
test util::logger::tests::test_logger ... ok
test util::state::tests::test_input_state ... ok
test util::keys::tests::test_action_keys ... ok
test util::command::tests::test_command ... ok
test record::fps::tests::test_fps ... ok
test edit::tests::test_edit ... ok
test app::tests::test_app_anim ... ok
test record::tests::test_record ... ok
test x11::display::tests::test_x11_display ... ok
test x11::window::tests::test_x11_window ... FAILED
test x11::tests::test_x11_system ... FAILED

failures:

---- x11::window::tests::test_x11_window stdout ----
thread 'x11::window::tests::test_x11_window' panicked at 'assertion failed: (left == right)

Diff < left / right > :
Geometry {
< x: 0,

x: 1366,
y: 0,
< width: 1366,
< height: 768,
width: 1920,
height: 1080,
}

', src/x11/window.rs:492:9
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

---- x11::tests::test_x11_system stdout ----
thread 'x11::tests::test_x11_system' panicked at 'assertion failed: (left == right)

Diff < left / right > :
<3147264

10646640

', src/x11/mod.rs:149:9

failures:
x11::tests::test_x11_system
x11::window::tests::test_x11_window

test result: FAILED. 34 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 4.70s

error: test failed, to rerun pass '--bin menyoki'

Let me know if I can provide any other details. If you prefer me to open a new issue for this let me know as well

from menyoki.

orhun avatar orhun commented on August 23, 2024

Hmm, that's unexpected. Can you increase the border width (e.g. --border 10) and see if shows up?

Failing tests are expected though. I used hardcoded values for the window dimensions. (They are meant to be run with xvfb, e.g. xvfb-run --server-args="-screen 0 1366x768x24" cargo test --features test-ws)

from menyoki.

anihm136 avatar anihm136 commented on August 23, 2024

Okay, the tests work with xvfb-run. But setting border width to 10 did not change anything, still shows the right thing on terminal but no border on screen

from menyoki.

anihm136 avatar anihm136 commented on August 23, 2024

Huh. That's odd. I was sure that it was working correctly with the released version (1.1.0), but checking now it seems to not show up even on that version

from menyoki.

orhun avatar orhun commented on August 23, 2024

That's weird. Did restarting X11 help?

from menyoki.

anihm136 avatar anihm136 commented on August 23, 2024

Nope. Just tried that too

from menyoki.

orhun avatar orhun commented on August 23, 2024

I'm trying to reproduce the issue and realized that borders are not visible at the start but they become visible when I move/resize them on my 1920x1080 monitor. Everything's fine on my other monitor. Maybe it's trying to draw them outside the screen boundaries. Can you confirm that if that's your issue or not?

Edit: It's showing the area size on the center of the screen as expected, right?

from menyoki.

anihm136 avatar anihm136 commented on August 23, 2024

Yes, the area size is seen correctly. However, the borders are definitely not seen at all. I verified this by doing menyoki capture --root --select --size $(slop), and selected a region in the middle of my screen. No borders show up

from menyoki.

orhun avatar orhun commented on August 23, 2024

It looks like it's time that I investigate this problem in a separate issue. Can you create a new issue where you provide the information about your system (OS, WM, X version, logs etc.) after closing this one?

from menyoki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.