Improvements to signature validation to prevent fake listings about openordex HOT 5 OPEN

i think this makes sense, lets be weary not to break existing clients though

but also, why is it difficult to validate these signatures when finalized? is it just due to the lack of support in bitcoinjs-lib?

from openordex.

Agree completely @dannydeezy. I think the first step would be to simply implement item 2 above. If the input is not finalized, validate the input rather than discarding the offer. This would allow other entities to not finalize inputs but still appear on openordex.

Regarding bitcoinjs-lib, I had to report a couple bugs to get signature validation to work for taproot addresses. The library does not support verification of finalScriptWitness. The tldr is that it is tricky because it requires current network state, scripts must be validated in addition to signatures and should probably be verified by bitcoin-core rather than a client-side lib.

You can read more on the subject here:
bitcoinjs/bitcoinjs-lib#1933
bitcoinjs/bitcoinjs-lib#1520

from openordex.

Hey,

I love this idea, and this should probably have been it was implemented from the get go.

Unfortunately, OpenOrdex is no longer actively maintained.

Feel free to use the NIP or this issue/repo as a schelling point of any kind for coordination of ordinal PSBT standards.

Best,
Oren

from openordex.

@timechainz were you ever able to find a way to extract the transaction and/or validate the final script witness?

from openordex.

@timechainz were you ever able to find a way to extract the transaction and/or validate the final script witness?

No, I haven't looked into it much other than the links and what I posted above. I think a better solution is to not prematurely finalize the PSBTs to allow clients to properly validate. I'm currently handling prematurely finalized PSBTs by showing the user a warning that the tx may fail.

from openordex.