`openSettings()` fails in menu-based MenuBarExtra about settingsaccess HOT 9 CLOSED

Oh yeah, that's a menu-based MenuBarExtra.

SwiftUI treats standard menus differently. Even though you're using a View, for menu items SwiftUI strips out everything except Buttons (Text and/or Image labels) and any view modifiers. Which means SwiftUI won't setup the internals for SettingsAccess to work.

Inside a menu, SettingsLink is sufficient to open Settings but it won't let you run custom code before or after it's clicked.

I'm not sure there is a solution for this specific scenario. I've tried a few approaches and nothing is sticking yet.

I will add a note to the readme in the interim that this is an unsupported use case until a solution can be worked out.

from settingsaccess.

Usually this happens if compiling with Xcode 14 (it needs Xcode 15).

from settingsaccess.

I've pushed release 1.1.0 which will now only compile on Xcode 15. That was originally intended and was a bit of an oversight to have allowed compiling on Xcode 14 which is where the error came from.

from settingsaccess.

this does not resolve the issue, it had been compiled with xcode 15 already, updating to the next minor still throws this exception

from settingsaccess.

I need more details about where you're using .openSettingsAccess() and where you're calling openSettings().

What it most likely means is the view that is getting .openSettingsAccess() is not being created or persisted.

from settingsaccess.

it's being chained onto mainmenuview in app.swift here

@main
struct ishare: App {
    @Default(.menuBarIcon) var menubarIcon
    @Default(.showMainMenu) var showMainMenu
    @StateObject private var appState = AppState()
    @NSApplicationDelegateAdaptor private var appDelegate : AppDelegate
    
    var body: some Scene {
        MenuBarExtra() {
            MainMenuView().openSettingsAccess()
        }
    label: {
        switch menubarIcon {
            case .DEFAULT: Image(nsImage: GlyphIcon)
            case .APPICON: Image(nsImage: AppIcon)
            case .SYSTEM: Image(systemName: "photo.on.rectangle.angled")
        }
    }
    .menuBarExtraAccess(isPresented: $showMainMenu)
        Settings {
            SettingsMenuView()
        }
    }
}

within MainMenuview the env is declared:

struct MainMenuView: View {    
    @StateObject private var availableContentProvider = AvailableContentProvider()
    @Environment(\.openSettings) private var openSettings
    
    var body: some View {
    ...

and then the method is called within a button

Button {
                NSApplication.shared.activate(ignoringOtherApps: true)
                openSettings()
} label: {
                Image(systemName: "gearshape")
                Label("Settings", image: String())
}.keyboardShortcut("s")

from settingsaccess.

Actually I think I've found solution. I'll try to push it today or tomorrow, just want to polish it up.

from settingsaccess.

Ok try release 1.2.0. The Demo project and readme are updated, but this is the gist:

• Remove .openSettingsAccess() from your MenuBarExtra menu view
• Inside MainMenuView, instead of your Button, use this:

  SettingsLink {
      Image(systemName: "gearshape")
      Text("Settings")
  } preAction: {
      NSApp.activate(ignoringOtherApps: true)
  } postAction: {
      // empty
  }
  .keyboardShortcut("s")

from settingsaccess.

lovely, whatever you did works much better than the actual SettingsLink component <3

from settingsaccess.