Allow updateIndex to be async about orbit-db-store HOT 4 CLOSED

Hi @fazo96! So happy to hear that OrbitDB is working for you! ❤️😄

Your idea to make updateIndex calls async sounds good! I don't see why we couldn't implement it as you propose.

Perhaps in addition to changing it internally in Store, we should also add async to the base class in https://github.com/orbitdb/orbit-db-store/blob/master/src/Index.js#L50 to make the intention of the public API clear.

Note also that updateIndex() gets called in multiple places inside Store: https://github.com/orbitdb/orbit-db-store/blob/master/src/Store.js#L416, https://github.com/orbitdb/orbit-db-store/blob/master/src/Store.js#L399, https://github.com/orbitdb/orbit-db-store/blob/master/src/Store.js#L202. It might make sense to create an internal async _updateIndex() function that calls the index as it does now and then on those ^ lines call this._updateIndex() function. This would make it a tad cleaner and easier to find what does what. What do you think?

Would be happy to review the PR and merge it in! If you do, make sure to run the tests in OrbitDB with the PR (npm link orbit-db-store && npm test) to make sure nothing breaks.

from orbit-db-store.

Did some clean up today, line numbers may not match anymore.

from orbit-db-store.

This was implemented in 9029c0f and merged to master. Will appear in the next release.

from orbit-db-store.

Wow thanks, looking forward to it! 👍

from orbit-db-store.