Git Product home page Git Product logo

Comments (7)

cshorler avatar cshorler commented on September 3, 2024 1

now successfully passes the test I wrote

from nurbs-python.

cshorler avatar cshorler commented on September 3, 2024 1

from nurbs-python.

orbingol avatar orbingol commented on September 3, 2024

Thank you @cshorler. I think slicing feature will be a nice addition to geomdl.

from nurbs-python.

cshorler avatar cshorler commented on September 3, 2024

I'll submit a PR for v6, a little difficult now a number of tests are failing on the branch 6.x-dev. I guess you're in the middle of some changes. I'll try skipping some commits of my current base to allow the rebase to work.

==================================== 14 failed, 92 passed, 134 error in 14.65 seconds ====================================
chorler@linux-tn2c:~/projects/src/NURBS-Python> git branch | cat
* 6.x-dev

from nurbs-python.

orbingol avatar orbingol commented on September 3, 2024

6.x-dev is very unstable at the moment. I am doing some major refactoring to simplify some algorithms which will improve the performance in general. I will post a list of current and future changes for 6.x in a couple of days. so you will be able to track the details.

I think it would be easier for you to work with 5.x series for now, a.k.a. devmaster branch. If you can keep the changes separate from the base library (such as, via extending the classes), it will be easier to port it to 6.x later. Still, I'd like to leave this decision to you. I'd be very happy if you could directly implement on 6.x-dev, but I can say that the code in that branch is going to change a bit.

from nurbs-python.

cshorler avatar cshorler commented on September 3, 2024

seems to work on 6.x-dev, see PR opened. Also, the NofityList mentioned in the comment on your other enhancement is used in the implementation.

from nurbs-python.

orbingol avatar orbingol commented on September 3, 2024

Would it be possible to create a separate PR for the NotifyList implementation?

from nurbs-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.