Bug in Map_Discard() about cello HOT 4 CLOSED

Maybe the inorder_key should be pushed back into md->keys after the recursive call.

from cello.

Thanks for the bug report and pull request. Yes it looks like the algorithm shouldn't really call discard recursively because actually it is doing a swap not a discard - but I think your fix is the simpliest way to deal with it because it is better not to write a separate swapping routine. Does your commit pass the test suite if you run make check?

from cello.

Yes. It did pass.

  +---------------------------------------------------+
  |                      Summary                      |
  +---------++------------+-------------+-------------+
  | Suites  || Total    6 | Passed    6 | Failed    0 |
  | Tests   || Total  117 | Passed  117 | Failed    0 |
  | Asserts || Total  698 | Passed  698 | Failed    0 |
  +---------++------------+-------------+-------------+

      Total Running Time: 0.096s

from cello.

Thanks I'll merge it in.

from cello.