Git Product home page Git Product logo

Comments (6)

woess avatar woess commented on May 18, 2024 1

Indeed, we should add a @GeneratedBy annotation. This also helps with navigating from the generated class to the source class in an IDE.

from graal.

jtulach avatar jtulach commented on May 18, 2024 1

Using @GeneratedBy is OK. Other option is to generate Javadoc and include @link references. Those are good for navigation as well.

from graal.

grimmerm avatar grimmerm commented on May 18, 2024

Where does SL throw such an exception?
AFAIK, SL is using Interop-DSL, which generates a Factory10 implementation (which throws an UnsupportedMessageException).

@jtulach returning null is not a good idea - I think the JavaDoc of Factory10 is wrong.
One has to raise an UnsupportedMessageException (i.e., doing UnsupportedMessageException.raise(Message.XXX); ).

from graal.

ldaynes avatar ldaynes commented on May 18, 2024

@grimmerm you can see throwing of these exception in the com.oracle.truffle.sl.runtime.SLxxxxMessageResolutionForeign classes. It's not clear that these are generated automatically -- nothing in the source indicate that, there's no @GeneratedBy or header comment telling so.

from graal.

chumer avatar chumer commented on May 18, 2024

@grimmerm please fix this.

from graal.

chumer avatar chumer commented on May 18, 2024

There are currently no plans to fix this minor issue.

from graal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.