Usernames with periods are not fully highlighted about activelabel.swift HOT 23 CLOSED

Yeah, I agree that might be a problem. At the moment usernames aren't configured to include a dot. I'll consider for the next version. I'll be possible to override the default regex for a username/hashtag/link.

Would that work for you?

from activelabel.swift.

Yup, that is something that would work. Looking forward to the next iteration!

from activelabel.swift.

Not happening anymore

from activelabel.swift.

No problem. Out of curiosity, what is the reasoning?

from activelabel.swift.

@ajfigueroa This issue is no longer happening, usernames with periods are now highlighted, so that's why I am closing it

from activelabel.swift.

@poolqf Awesome, thanks :)

from activelabel.swift.

Hello! It seems this is happening again.

Any idea how to fix it?

Thank you!

from activelabel.swift.

Reopening it. Thanks for the heads up @2mittens

from activelabel.swift.

After digging a bit in the sources, I noted that the Cocoapods regex is different from the GitHub one, maybe is outdated?

The problem however is present in both version, but I was able to solve it just adding . to the Cocopods one, having the whole regex like this:
(?:^|\\s|$|[.])@[a-z0-9_.]*

Does this help?

from activelabel.swift.

Hm, strange the thing about the different regex, I'll take a look into it.

Yep, the regex needs to allow the . as a valid username character

from activelabel.swift.

Before any edits they're like this:

GitHub:
(?:^|\\s|$|[.])@[\\p{L}0-9_]*

Cocoapods
(?:^|\\s|$|[.])@[a-z0-9_]*

Adding a . to Cocoapds regex resolve the issue, but it doesn't on the repo one.

Hope I was helpful and thank you!

from activelabel.swift.

(?:^|\\s|$|[.])@[\\p{L}0-9_.]* This regex is working for me

from activelabel.swift.

Also with mentions with a dot in it? Because for me is working for @UserHandle, but not for @userhandle.dotted!

from activelabel.swift.

https://regex101.com/r/kJ1pY6/1

from activelabel.swift.

My bad, I wasn't building properly the framework before testing the demo. So yes, just adding the point to the regex solves the matter.

Thanks for the help!

from activelabel.swift.

this issue is still happening, any workaround?

from activelabel.swift.

There was a fix I reverted because of side effects...

from activelabel.swift.

We have this issue too. Is there a way to customize the Regex without cloning the project?

from activelabel.swift.

@polqf we have the same issue, should we fix it on our fork?, or wait for your solution?, i'm asking because you reverted a fix due to side effects.

from activelabel.swift.

Are there any news on this?

from activelabel.swift.

same as #228, added some options of regex to fix it, will try to have a PR soon

from activelabel.swift.

i have a fix working, will make the changes in the swift 4 version and create the PR next week

from activelabel.swift.

Hi, Word does not fully highlighted when contain any special letter like (&, +, -). I am using below regex pattern -

static let mentionPattern = "(?:^|\s|$|[.])@[\p{L}0-9_]*"

Please help me.

from activelabel.swift.