Git Product home page Git Product logo

Comments (7)

seanlip avatar seanlip commented on July 23, 2024 1

Hi @priyanshuverma-dev, thanks for your interest in helping out with this issue. Could you please provide a video demonstration of the fix working on your local machine? Make sure that the URL bar is shown and that it starts with "localhost:8181".

Thanks.

from oppia.

priyanshuverma-dev avatar priyanshuverma-dev commented on July 23, 2024 1

@seanlip Here is the demo and code changes.
PR filed #20537

Demo

social-media-icon-size-fixed.mp4

File Changed

sharing-links.component.html.mp4

from oppia.

priyanshuverma-dev avatar priyanshuverma-dev commented on July 23, 2024

May I work on this issue @natashabag

I can fix this by changing CSS in

https://github.com/oppia/oppia/blob/a7439c3fe735d651afff38792358edef6ff1af7a/core/templates/components/common-layout-directives/common-elements/sharing-links.component.html#L10C8-L10C13

from oppia.

navyansh007 avatar navyansh007 commented on July 23, 2024

Hello @natashabag, has the issue been resolved. If not, please assign this issue to me and I will start working towards fixing this bug.

from oppia.

seanlip avatar seanlip commented on July 23, 2024

@navyansh007 Per the guidance at https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#choosing-a-good-first-issue, please provide an explanation of what your PR will do (with names of files you're changing, what you plan to change in each file, etc.). If it looks good, we can assign you to this issue.

Please also follow the other instructions on that wiki page if you have not yet done so. Thanks!

from oppia.

priyanshuverma-dev avatar priyanshuverma-dev commented on July 23, 2024

Gotcha! Setting up dev environment @seanlip

from oppia.

github-actions avatar github-actions commented on July 23, 2024

Hi @HardikGoyal2003, thanks for proposing this as a good first issue. I am removing the label for now and looping in @DubeySandeep to approve the label. It will be added back if approved. Thanks!

from oppia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.