Git Product home page Git Product logo

Comments (8)

github-actions avatar github-actions commented on July 19, 2024

Hi @amyyeung17, thanks for proposing this as a good first issue. I am removing the label for now and looping in @DubeySandeep to approve the label. It will be added back if approved. Thanks!

from oppia.

seanlip avatar seanlip commented on July 19, 2024

@amyyeung17 Is this failing locally or on CI?

@masterboy376 I think this might be related to #19979. Could you PTAL? Not sure if you need to specify a locale somehow when declaring the Date in the test.

from oppia.

masterboy376 avatar masterboy376 commented on July 19, 2024

@amyyeung17 @seanlip , I belive this is happening due to different timezones. We have to explicitly mention en-us locale at the time of date declaration.

from oppia.

seanlip avatar seanlip commented on July 19, 2024

Thanks @masterboy376. Can you fix the affected test? When a test is introduced, it has to work for all devs, otherwise we need to revert the PR that introduced it.

from oppia.

masterboy376 avatar masterboy376 commented on July 19, 2024

@seanlip ,
Sure I can do it. So, should I create a new PR for solving this one?

from oppia.

seanlip avatar seanlip commented on July 19, 2024

Yes, ASAP please. Thanks.

from oppia.

masterboy376 avatar masterboy376 commented on July 19, 2024

Hello @amyyeung17, Is this failing locally or on CI check.

from oppia.

seanlip avatar seanlip commented on July 19, 2024

Fixed by #20505. Thanks @masterboy376!

from oppia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.