Comments (10)
Hi @Akhilesh-max! I'd love to take on this issue.
from oppia.
Hi @sidharth-05, that would be great!
However, before do we assign you, according to the guidelines, it would be really helpful if you could provide a brief explanation of what your PR will do. This includes the names of the files you’re planning to change and what modifications you intend to make in each file. If everything looks good, we’d be more than happy to assign you to this issue.
Thanks.
from oppia.
To resolve the issue of the input field being invisible, I can simply add the ‘visibility: visible;’ property to ensure the text is displayed correctly. This adjustment should be made in the relevant CSS section for the oppia-promo-bar-config-field class.
FilePath: oppia/core/templates/pages/release-coordinator-page/release-coordinator-page.component.html’
With this change, the input should be visible and not hidden. If this is not the issue most likely it is a problem in the HTML Structure.
If all is well, PR should be made in 1-2 days.
Final question: I also wanted to ask whether anyone has addressed a way to speed up the time to start the developer server? Currently, it seems to take atleast 10 minutes to start up which seems a bit too long.
from oppia.
@sidharth-05 There's one more thing we need to ask you. Why is this bug happening in the first place -- what PR caused it? (See the "Tips for developers" in the issue description.)
Understanding this is important to verify that what you propose is actually the correct fix, and not a hack.
For the question about the dev server, please start a new thread in GitHub Discussions for it, and provide more details so that the dev workflow team can take a look at it. Thanks!
from oppia.
@seanlip @Akhilesh-max After checking git blame, I believe the issue was caused from PR #18326. This was the most recent PR about an year ago. In this PR the 'Promo-bar config' changed to 'Enable Promo-Bar' and same for the Promo-Bar message. If in fact, this issue was not present while developing the release-coordinator-page.component.html file this must be the reason for the invisible field. But, nothing prompts me to think anything that was changed for the PR, would cause the issue though as none of the CSS code was changed only the names of the labels.
from oppia.
Ah, good find, thanks -- I took a look at the video on that PR and the field is missing there, so I think you are probably right that this was an issue since the feature was introduced. /cc @lkbhitesh07 for info.
One last thing to check: can you show a video/screenshot of the promo bar after your proposed changes?
from oppia.
@seanlip Here is the video of the new update.
Recording.11.mp4
Lmk when I should make the PR.
from oppia.
@sidharth-05 If I'm looking at the video correctly, the input field still doesn't seem visible before you click it?
from oppia.
@seanlip Sorry I submitted the wrong video. Here is the correct one:
Recording.12.mp4
Changing the visibility was not the only issue it seems, because it would still disappear when you click out of it. So I just added a box on css for this the updates I made to the code are below. Lmk if any changes.
from oppia.
@sidharth-05 I've assigned you, thanks. Go for it!
from oppia.
Related Issues (20)
- TODO(sll) in core/controllers/reader.py: `client_time_spent_in_secs` HOT 1
- [Flake]: Questions List Component should close question editor save modal if user clicks cancel HOT 1
- [Flake]: Topic in Skill Proficiency takes too long to appear HOT 1
- [Feature Request]: Implement concurrent backend unit test case running.
- Remove CD accomplishments feature flags HOT 1
- [Feature Request]: Add voiceover functionality in hint and soolutions modal
- Beam job to audit Topic and related to models to ensure they are valid
- [BUG]: 404 Error Displayed Instead of Redirecting to Login Page When Accessing Preferences Page While Logged Out
- [BUG]: TODO(sll): Allow the warning to be more specific in terms of what needs to be entered.
- [BUG]: TODO(bhenning): Integrate Immutable.js to avoid the slice and ensure the returned object is truly an immutable copy.
- [BUG]: TODO(sll): Get rid of the $timeout.
- [BUG]: TODO(kashida): Split the section into two.
- [BUG]: Email Dashboard Queries Show Incorrect Qualified Users and Never Complete.
- [Feature Request]: Enhancing Acceptance Test Directory Organization
- [BUG]: Capslock button doesn't work in an Algebraic expression input interaction HOT 2
- [GSoC'24 M1+M2]: Acceptance Test Coverage for Learner's and Admin's CUJs.
- [BUG]: CI Error: The operation was canceled. HOT 6
- [BUG]: TODO(bhenning): Split the validation tests into separate unit tests.
- [Feature Request]: Notify developer onboarding leads about new contributors merged PRs HOT 5
- [Flake]: Can't call $ on element with selector ".e2e-test-exploration-dashboard-card" because element wasn't found
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oppia.