Comments (8)
From analysis of Windows .exe releases here:
it was found that 20220803 release works and entries are sorted, but 20220817 release does not work and the entries are not sorted there.
The 20220817 release is just after the 20220803 release, and therefore we can assume that changes made here must have lead to somehow break the sorting.
from opossumui.
Changes were made to one of the relevant components via this commit.
Although, the component that directly influences this data, has not been changed anytime recently and neither has the commit in question directly modified the way this data is called for.
Therefore, it is assumed that the commit has somehow indirectly introduced the bug.
from opossumui.
Some useful git stuff:
- Find a commit with particular commit message: Link
- How to reset/revert a file to a specific commit: Link
from opossumui.
The changes made by the commit to the component were reverted, and we tested if sorting is fixed. However, sorting is still not fixed. Thus, it can be concluded that the changes made to this particular component by the commit did not introduce the bug.
However, we will now try to completely revert the commit in question (and not just the changes in particular components) and see if the commit itself somehow introduced the bug (via some indirect changes).
from opossumui.
Resetting the repository to the following commit, resolves the bug:
Basically, the above commit is 1 commit before the commit we have been interested in.
To further confirm that commit may have caused the issue, we will now try to just revert that particular commit instead of resetting the entire repository to before that commit.
from opossumui.
Reverting the commit of interest (see image below), is leading to merge conflicts, following which the OpossumUI application cannot be tested, since it doesn't start because of merge conflict markers in code. We need to resolve this conflict to proceed.
from opossumui.
Resolving merge conflicts from #989 (comment) proved difficult and so we took another approach.
Resetting the repository to the following commit, still has the bug:
However, from #989 (comment) we know that resetting to a commit just before the commit in the image above makes our application free of this bug. Therefore, it can be firmly concluded that commit has introduced the bug. Also from #989 (comment) and #989 (comment), we know that direct changes in relevant component files have not caused this bug, but changes in other files have indirectly caused this bug.
from opossumui.
Verbal discussion: Probably we are alphabetically re-sorting the already sorted attributions that are coming from the workers, leading to this bug at hand.
from opossumui.
Related Issues (20)
- Display license short names in license autocomplete
- Do not highlight missing attribution versions
- "License text modified" overlaps with license name on smaller screens
- Scroll bar in multi-line textfields is misaligned
- Remove feature to work with deprecated file format
- Create better support for license expressions HOT 1
- Cache colours in Resource Tree to speed up navigation HOT 1
- Update USER_GUIDE.md HOT 1
- Race conditions for in folder content HOT 1
- fix: alignment of scroll bar and end adornment TextField
- Compare attribution to any other attribution/signal
- Create a proper error boundary
- Compare attributions and signals HOT 1
- Fix hover colour in Diff Popup for fields that are coloured green or red HOT 1
- Enable keyboard navigation in resource browser
- Pressing "cmd+s" on an already saved/confirmed attribution delets the attribution HOT 1
- Reintroduce "cmd+f" shortcut for quick search of resources HOT 1
- Automatically map license names to SPDX license identifiers HOT 1
- Work on multiple Opossum files simultaneously
- Improve progress bar
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opossumui.