Git Product home page Git Product logo

Comments (7)

lhanson avatar lhanson commented on July 19, 2024

After some googling, I discovered that gather_subset and gather_timeout are part of the built-in setup module (https://docs.ansible.com/ansible/latest/modules/setup_module.html) automatically called by playbooks. Sensing some namespace clashing here, I removed the collections: block from the play, and this worked:

- name: Configure pfSense
  hosts: pfsense
  remote_user: 'root'
  tasks:
    - name: General setup
      pfsensible.core.setup:
        timezone: America/Chicago

I was basing my usage on the example and subsequent comments explaining the new task name changes in #39. So perhaps some documentation clarity would help others avoid the same trap?

from ansible-pfsense.

opoplawski avatar opoplawski commented on July 19, 2024

Using collections: in a playbook just seems like a recipe for disaster. I'm not sure how one is expected to avoid namespace collisions using that.

from ansible-pfsense.

lhanson avatar lhanson commented on July 19, 2024

This is my first encounter with collections, so I was just trying to piece together how it's supposed to work. The ansible documentation specifically mentions using collections in playbooks, so it didn't seem that far-fetched since it wasn't working to begin with because ansible had no idea what I meant by pfsense_setup, and I didn't know the examples in the documentation were wrong.

from ansible-pfsense.

opoplawski avatar opoplawski commented on July 19, 2024

Part of the issue is that we have two versions of "ansible-pfsense" - this repository which was organized around eventual merging into ansible proper, and "pfsensible{.core}" which is structured like a collection. pfsensible is currently built by a script using ansible-pfsense as the source. There is no separate wiki docs for pfsensible yet.

from ansible-pfsense.

lhanson avatar lhanson commented on July 19, 2024

Ok, thanks for the info. I'll be watching with interest as I'm trying to ansible-ize as much of my pfSense install as I can, and will try to help out if I can.

from ansible-pfsense.

opoplawski avatar opoplawski commented on July 19, 2024

I've filed ansible/ansible#69195 to try to get some better clarification from ansible about module name collisions. However, I think we're going to want to switch the pfsensible.core module names back to the pfsense_ prefixed versions to avoid these collisions. I'm not sure that adding collections to the namespace search was an option when we first started on the pfsensible.core collection and I was wanting to avoid long module names. Having the search path avoids that.

We would need to announce the change well though as it will break existing usage, but now may be the time to do it.

from ansible-pfsense.

opoplawski avatar opoplawski commented on July 19, 2024

Will be keeping the pfsense_ module name prefixes.

from ansible-pfsense.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.