IDEA 13.1 about gitflow4idea HOT 8 CLOSED

Thanks for the heads up!

from gitflow4idea.

Had the same problem and after some fiddling around got it working, or at least it compiles and I am able to load the plugin and see the gitflow in main screen. Main changes are the plugin idea-version and the GitUIUtil.notifySuccess does not exist anymore use GitUIUtil.notifyMessage instead and add two extra parameters. I had a bit of difficulties getting the project to build, isn't it possible to mavenize the project

from gitflow4idea.

I came across the same issue - looks like GitUIUtil was updated in this build. The xml change is a given.
Some work is needed to both fix the issue of this version as well as make it compatible for the previous ones.

I know @avogler is looking into it, we can use this thread for discussion on solutions\progress.

from gitflow4idea.

True, I've created a feature branch is which I made the changes needed to get it working and the resulting plugin is now installed and seams to be working fine. The part where I am not sure is in TrackReleaseAction

•        new Notification(GitVcs.IMPORTANT_ERROR_NOTIFICATION.getDisplayId(), "Error", "No remote branches", NotificationType.ERROR).notify(myProject);
  

•        GitUIUtil.notifyImportantError(myProject,"Error","No remote branches");
  

Date: Tue, 25 Mar 2014 13:35:57 -0700
From: [email protected]
To: [email protected]
CC: [email protected]
Subject: Re: [gitflow4idea] IDEA 13.1 (#31)

I came across the same issue - looks like GitUIUtil was updated in this build. The xml change is a given.

Some work is needed to both fix the issue of this version as well as make it compatible for the previous ones.

I know @avogler is looking into it, we can use this thread for discussion on solutions\progress.

—
Reply to this email directly or view it on GitHub.

from gitflow4idea.

I got it working for 13.1 but my solution isn't backward compatible. Did you find a way that works both in 12.x and 13.1?

from gitflow4idea.

Here's the culprit:
JetBrains/intellij-community@d6528d3#diff-fbc57e5534fd96ea8d61d2eb83c0386a

@NadyaZabrodina refactored the GitGuiUtil class to use VcsNotifier.
I'll try to see if we can use that instead of GitGuiUtil. Hopefully that's backwards compatible.

from gitflow4idea.

Unfortunately VcsNotifier is not available in older versions, that was what I tried to use.We could decouple gitflow4idea from git4idea here and replicate the functionality of VcsNotifier within gitflow4idea but thats rather ugly.

from gitflow4idea.

Hmmm... damn
This means that in order to preserve backwards compatibility, we'll have to use reflection to poll the git4idea interface for the right signature.

Maybe instead of replicating VcsNotifier we can write a utility class for notifications that does this for us , and use that as middleware for invoking notifications.

Something along the lines of
http://stackoverflow.com/questions/7058621/how-to-check-if-a-method-exists-at-runtime-in-java

from gitflow4idea.