Setup publishing about zipkin-aws HOT 15 CLOSED

@abesto thanks for the follow up. I've used maven a lot but never tried to get it working with tag releases from a CI environment. I will just run with what you have so far, it seems close to the release process used for Zipkin. No need to deviate from a process that is clear for others and already works :)

Now that PR builds are running I am going to make another PR with your release scripts and debug as necessary.

from zipkin-aws.

I think the first run failed because there was already some 0.0.1 artifacts in Bintray. I removed those and reran it. The artifacts in Bintray looks OK now though it failed to create the 0.0.1 tag in Github. The error message indicated that the 0.0.1 tag already existed even though I deleted it.

Since the tagging worked the first time I'm going to assume that when the next version is released all will be fine.

from zipkin-aws.

cc @abesto no action needed

from zipkin-aws.

@abesto actually.. would you mind using this repo to try out circle-ci publishing (ex travis-free)? I think the maven config is correct now thanks to @llinder

from zipkin-aws.

Sure thing! I'm 70% sure I'll get to it this weekend.

from zipkin-aws.

https://app.classeur.io/#!/files/fatM2T9a64NVS8HZopiE looks like a decent write-up of how to set things up. I'll try to apply it to this repo. Work is in the branch circleci.

Update: not gonna muddy the waters with the "parameterized build API" part, keeping the git-tag-triggered release process.

from zipkin-aws.

@adriancole I won't be able to finish this up today, stuff came up. If you (or anyone else) wants to pick it up, here's how things stand. Everything is in the circleci branch. Interesting part of circle.yml: https://github.com/openzipkin/zipkin-aws/blob/circleci/circle.yml#L34-L49

The intended release logic:

• Do nothing on PRs and when building anything other than the master branch of the original fork (Implemented by not matching these cases. Need to verify: PRs against master don't match the branch: master rule in circle.yml)
• When building a tag release-NUM.NUM.NUM, ask Maven to prepare for the release (set version numbers, create tag NUM.NUM.NUM). Implemented by section deployment.trigger.
• When building a tag NUM.NUM.NUM, do a stable release. Implemented by section deployment.publish-stable.
• When building master on openzipkin, do a snapshot release. Implemented by section deployment.publish-snapshot.

https://circleci.com/gh/openzipkin/zipkin-aws/6 failed because the scripts expect releases to happen on master, and this one was on a branch, so it got confused. Otherwise, I think we're on a good track.

Secret ENV vars are not set on CircleCI (yet).

from zipkin-aws.

Looks like a good start. Besides a PR, review and ENV vars, whats holding this back from being merged at this point? I'm willing to help move this forward by making a PR but will need to have someone ensure the ENV vars are setup.

from zipkin-aws.

One thing that I am curious about is the reason for not combining deployment.trigger and deployment.publish-stable into one action using mvn release:prepare release:perform? I'm sure there is a good reason... just not familiar with what it is :)

from zipkin-aws.

I think that's it no other steps needed. Other than debugging why it
doesn't work after all that is done.

As for combining the two phases: in theory it should be fine. I don't know
mvn very deeply, so my instinct is keeping what worked. But merging them
feels cleaner.

On Tue, Oct 11, 2016, 1:41 AM Lance Linder [email protected] wrote:

One thing that I am curious about is the reason for not combining
deployment.trigger and deployment.publish-stable into one action using mvn
release:prepare release:perform? I'm sure there is a good reason... just
not familiar with what it is :)

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#4 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADqTo6qmq3OQp0IIPqcARGAkoqZmODPks5qys0-gaJpZM4KKoAT
.

Zoltán Nagy
https://abesto.net

from zipkin-aws.

Like Adrian said, thanks for taking this on!

from zipkin-aws.

from zipkin-aws.

from zipkin-aws.

ps I just synced manually via https://bintray.com/openzipkin/maven/zipkin-aws#central

from zipkin-aws.

Awesomeness. Great stuff!

@llinder To expand on what @adriancole wrote re. deleting tags: when you git tag -d $TAG, that removes the tag from your local version of the repository. We assume this is what you did. You then also need to remove the tag from the remote (GitHub) version of the repo, which is what the command by Adrian does: it pushes "nothing" (the stuff before the colon) to the tags release-0.0.1 and 0.0.1, which is how you tell git to delete those tags.

from zipkin-aws.