Git Product home page Git Product logo

Comments (8)

ikreymer avatar ikreymer commented on May 30, 2024 1

I think it happens with other ZIMs too, ex:

Screen Shot 2020-10-27 at 2 49 57 PM

from zimit.

ikreymer avatar ikreymer commented on May 30, 2024

This is coming from the padding-top skin.css in kiwix-serve. I guess it could be overriden, but assume it was set from some other calculation there?

body {
    padding-top: 3em !important;
}

from zimit.

kelson42 avatar kelson42 commented on May 30, 2024

Then why it seems to be visible only in case of zimit zim?

from zimit.

kelson42 avatar kelson42 commented on May 30, 2024

Ok I will investigate why it fails as well on this youtbe based ZIM.

from zimit.

kelson42 avatar kelson42 commented on May 30, 2024

@ikreymer I have tested and this is not the samee stuff: ubongo slides nicely (without white band) behind the taskbar if you scroll. Zimit don’t.

from zimit.

ikreymer avatar ikreymer commented on May 30, 2024

Yes, the scrolling happens in an iframe, which is fixed, so that's why it won't move, but it is there whenever you use kiwix-serve. To fix it, I think you just need to adjust the padding in kiwix-serve ui to be slightly smaller:

body {
    padding-top: 3em !important;
}

It wouldn't make sense to add a kiwix-serve specific override to the zims, since it would then be incorrect if the size of kiwix-serve bar later changes.

from zimit.

ikreymer avatar ikreymer commented on May 30, 2024

You could do something like padding-top: calc(3em - 8px) !important

from zimit.

rgaudin avatar rgaudin commented on May 30, 2024

This is upstream. Easily verifiable by adding body { background-color: red; } on any ZIM
See this fix: kiwix/libkiwix#422

from zimit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.