Git Product home page Git Product logo

Comments (2)

ikreymer avatar ikreymer commented on May 30, 2024

Unfortunately, there's not a good fix for this, other than double quotes, eg. --tag "'some;param'" as the params are first handled by bash, then passed to JS, then passed to warc2zim. This would also affect other characters that are shell commands, like &.

I can see about removing the bash script, but it does many useful things now, as far as changing permissions, creating dirs, trapping signal, etc.. which would otherwise have to be implemented in JS.

Because crawling often involves lots of complex options, the general practice is to use config files instead of trying to send all parameters on the command line.

To simplify creating specifying parameters, my recommendation would be to support a yaml based config file, which could be passed in as a volume or even be part of the output volume, eg. docker run -v /my/config.yaml:/config.yaml -it openzim/zimit zimit --url https://example.com/. The config file could then specify the warc2zim command-line nicely:

warc2zim_opts: "--tag=a;b --publisher Test Publisher"

as well as other options which may be common to different types of crawls.

from zimit.

rgaudin avatar rgaudin commented on May 30, 2024

The obvious solution is to replace that shell script with a python one. Will be a lot clearer. You could even import warc2zim to check its part of the paeans...

Or am I missing something ?

from zimit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.