Comments (2)
- What does it apply to?
await page.goto(url, {waitUntil, timeout});
implies it's the time for the page toload
(that's the defaultwaitUntil
value). Is this the time before the document loaded event?
Yes, the timeout applies to the various 'modes' of the goto function.
It could wait for either just the dom loading, or until there is no more network traffic.
The options are better explained here:
https://github.com/puppeteer/puppeteer/blob/v5.3.1/docs/api.md#pagegotourl-options
- What we be the consequences of increasing it?
It depends. Maybe its good to just set it to 1 min. For sites that load quickly, there should be no affect.
- How are non-page requests affected? Like video files for example.
They would not be included in this.. There will be separate logic, part of #9, to handle waiting for video playing.
Also, the timeouts could be for any number of reasons.. for example, I've seen more timeouts when too many browsers are running and there is not enough CPU..
from zimit.
OK, thanks for the details. I think we should increase the default then. Maybe 90s?
I think we shall also document in the --scroll
option help its custom timeout.
You mentioned the separate behavior for video but what about non-video resources? Images, or large non-media files like JS or WASM files? Is there a timeout at play there?
Thanks for pointing to the concurrency issue ; indeed that must be taken into consideration when writing recipes. Network is also affected although I understand for most cases, bottleneck would be CPU.
from zimit.
Related Issues (20)
- Doesn't work on aarch64 HOT 2
- Best way to self hose YouZim.it equivalent? HOT 1
- What is the advanage HOT 3
- Error when building docker image HOT 8
- Support Linux/ARM64 architecture HOT 1
- Full scrape fails while limited one succeeds HOT 2
- External links should not be open in a new tab HOT 1
- Handling of external links seems incoherent HOT 1
- Non-clickable link HOT 1
- NDLA recipe failed HOT 1
- Frequent initial connect timeouts
- New zim should not be defaulted to English HOT 7
- Better auto-detection of multilanguage content HOT 1
- Zim files on Library Education on Wikipedia HOT 1
- dp.la recipe succeeded but file is not complete HOT 1
- Issues with task 672c1 HOT 35
- Conflicting lang param
- MIT OpenCources Recipe issue HOT 1
- ZIMit 2.0 HOT 4
- Use browser-generated text as IndexData
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zimit.