Use EIP-1967 for Ownable storage about openzeppelin-contracts HOT 5 CLOSED

Hello @pegahcarter

If you want a version of Ownable that uses a dedicated storage slot, you should consider using the upgradeable version.

from openzeppelin-contracts.

It appears that all of the storage is private in both cases with internal/external methods to access, so the only difference should be gas.

The main difference is that upgradeable contracts are upgradeable, just that. Of course, upgradeability comes with extra gas costs because they are exposed behind a proxy and can't take advantage of immutable variables, among other considerations.

Please refer to our Upgradeability docs so you can get more information.

Personally, I think the bottom line is that if you need an upgradeable contract, you'll have to inevitably deal with the extra costs, not even optimizing would help much and may be dangerous.

from openzeppelin-contracts.

Hey @Amxx thank you. Is there a reason why the upgradeable version isn't the de-facto?

from openzeppelin-contracts.

Smart Contracts are de-facto non-upgradeable, upgradeability is a set of quirks we make to simulate upgradeability, but it comes with a bunch of constraints and considerations.

Most projects are better off writing non-upgradeable code, and in our opinion, they should consciously go for upgradeability and not deal with their complexities by default.

from openzeppelin-contracts.

Are there additional costs to using the upgradeable Ownable that makes it more beneficial to use the non-upgradeable version? It appears that all of the storage is private in both cases with internal/external methods to access, so the only difference should be gas.

from openzeppelin-contracts.