Git Product home page Git Product logo

Comments (6)

rloutrel avatar rloutrel commented on July 26, 2024 1

Patch submitted. I had to create a new mail address to avoid mine to be public.

Quite a bit complicated process, but I hope I helped.

from openvpn3-linux.

dsommers avatar dsommers commented on July 26, 2024

Hi,

Thanks for the report. These all seems to be options we need to add to the ignore list; neither of them exists for the OpenVPN 3 Core library and they make little sense in the OpenVPN 3 context. For the time being, --route-method, --mute and --route-delay can all be removed from your current config.

I will try to remember to fix this for the next v14_beta release.

from openvpn3-linux.

rloutrel avatar rloutrel commented on July 26, 2024

I am working on a PR. For the mute parameter it seems quite easy. for the 2 others, I am not sure about the acceptable formats.

Is there anywhere an official documentation?

from openvpn3-linux.

dsommers avatar dsommers commented on July 26, 2024

Awesome! Please send these patches to the [email protected] mailing list; see the wiki page for some more details: https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation

All of these three options can go into the "ignored section" of ConfigParser.py. For the option syntax, see the OpenVPN 2.x man pages (--route-method, --route-delay)

from openvpn3-linux.

dsommers avatar dsommers commented on July 26, 2024

Great! Thanks a lot! I will review it properly next week and merge it. At first glance it looks good.

The process may seem complicated, but it ensures that the review is preserved even if GitHub disappears in the future, due to the distributed nature of e-mail and mailing lists. It will always be possible to nest up why a change appeared later, something which is important for security products like VPN solutions.

from openvpn3-linux.

dsommers avatar dsommers commented on July 26, 2024

Thank you very much. This has been reviewed and applied to git master, commit b1a2700

from openvpn3-linux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.