Git Product home page Git Product logo

Comments (10)

1480c1 avatar 1480c1 commented on May 27, 2024 1

This can be closed

from svt-hevc.

hassount avatar hassount commented on May 27, 2024

@tessus
Thank you very much for your feedback.
Currently SVT-HEVC does not have a support for MAC OS, however, we welcome contributions for adding such support.

from svt-hevc.

tessus avatar tessus commented on May 27, 2024

we welcome contributions for adding such support.

What exactly would this entail? Is it just the build script that needs to be adjusted, or does assembly code have to be re-written?

from svt-hevc.

hassount avatar hassount commented on May 27, 2024

no assembly code to be re-written, I believe it would be some cmake / build scrip changes along with some compiler flags to make sure the code builds, after that it should just run.

from svt-hevc.

tessus avatar tessus commented on May 27, 2024

Ok, I think I can have a look at it. Although it will take a while, because I'm currently rather busy.

However, I do have a few questions / comments:

  • a more detailed documentation would be nice how to build the library (the build script is great, but doesn't really explain any of the options. some people would like to know what the different cmake options mean and do.)
  • how do I currently build a static library (on Linux)?
  • do I have to use the --enable-nonfree option for ffmpeg? If so, I cannot distribute this library with my static ffmpeg binaries (which would be a shame, because there was already a request to add it to my binary)
  • I suggest you open a PR with ffmpeg to add the wrapper to the ffmpeg code base

from svt-hevc.

tianjunwork avatar tianjunwork commented on May 27, 2024

@mypopydev what is your insight about the 3rd and 4th question from @tessus?

from svt-hevc.

tessus avatar tessus commented on May 27, 2024

Yep, I really would like to hear the answers, otherwise it makes no sense for me to get it working on macOS and then not being able to actually use it.

from svt-hevc.

hassount avatar hassount commented on May 27, 2024

@tessus
I apologize for the late reply, please find below my answers:

  • For point 1, could you please create an issue, stating which options do you need clarity on ?
  • This should be feasible by changing the CMake files of the library to create a static and link it to the application, if you require assistance with this, please add a separate issue for this item too.
  • Definitely not, not even gpl is needed, we'll be addressing this in the next commits, this is a free library licensed under the BSD+Patent license and so you can use it as you wish.
  • This is already in progress, we have already opened the PR and are working on feedback from the ffmpeg community.

from svt-hevc.

tessus avatar tessus commented on May 27, 2024

@hassount Thank you very much for your reply.

I will open separate issues for item 1 and 2.

Definitely not, not even gpl is needed, we'll be addressing this in the next commits, this is a free library licensed under the BSD+Patent license and so you can use it as you wish.

I've noticed that the --enable-nonfree has been removed from the README.txt. Thanks.

This is already in progress, we have already opened the PR and are working on feedback from the ffmpeg community.

Have you already sent the new patch to the ffmpeg-devel mailing list?

from svt-hevc.

1480c1 avatar 1480c1 commented on May 27, 2024

So, I've got it to 94%, https://travis-ci.org/1480c1/SVT-HEVC/jobs/499613916#L549 however I am erroring out at Undefined symbols for architecture x86_64:. It would be nice if someone could help. My knowledge of C comes from stackoverflow and looking at some man pages, on windows.

Idk if my modifications would actually work since I'm basically looking if the same headers from linux are present on Mac and changing #if __linux__ to #if __linux__ || __APPLE__ for some and I had a rough time with cpu_set_t.

from svt-hevc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.