Git Product home page Git Product logo

Comments (9)

dkulchinsky avatar dkulchinsky commented on June 12, 2024 1

I worked around point (2) above by creating a cert-manager Certificate resource that populates it in a secret that the Ingress then consumes, this seems to work well.

from openunison-k8s-login-oidc.

mlbiam avatar mlbiam commented on June 12, 2024 1

Our next release of the operator supports adding annotations to the ingress definition. we'll also support disabling the creation of ou-tls-certificate

from openunison-k8s-login-oidc.

dkulchinsky avatar dkulchinsky commented on June 12, 2024

To be more specific, we're using cert-manager (https://cert-manager.io/) to Issue Let's Encrypt certificates, so cert-manager will populate the ou-tls-certificate secret with the Certs from Let's Encrypt, but how to ensure the operator is not going to override it?

maybe we need to remove this section from the OpenUnison manifest?

        - create_data:
            ca_cert: true
            key_size: 2048
            server_name: {{ .Values.network.openunison_host }}
            sign_by_k8s_ca: false
            subject_alternative_names:
              - {{ .Values.network.dashboard_host }}
              {{ if eq .Values.enable_impersonation true }}
              - {{ .Values.network.api_server_host }}
              {{ end }} 
          import_into_ks: certificate
          name: unison-ca
          tls_secret_name: ou-tls-certificate

from openunison-k8s-login-oidc.

mlbiam avatar mlbiam commented on June 12, 2024

this is a reasonable request.

maybe we need to remove this section from the OpenUnison manifest?

Precisely

from openunison-k8s-login-oidc.

dkulchinsky avatar dkulchinsky commented on June 12, 2024

great 👍 I'll try that, but I think we're also missing the ability to add an annotation to the ingress:

cert-manager.io/issuer: "letsencrypt-staging"

if I update the ingress manually, will the operator change it back?

from openunison-k8s-login-oidc.

mlbiam avatar mlbiam commented on June 12, 2024

if I update the ingress manually, will the operator change it back?

No. The other option is to create a Certificate object so you don't need to add the annotation

from openunison-k8s-login-oidc.

dkulchinsky avatar dkulchinsky commented on June 12, 2024

Just managed to glue this together 😄

  1. Removed the ou-tls-certificate create_data block from orchestra
  2. added the cert-manager annotation to the ingress

I guess my only ask is to be able to add custom annotations to the generated ingress resource 🙏

This method is preferred because it ensures cert-manager keeps track of all the ingresses and updates them accordingly.

from openunison-k8s-login-oidc.

dkulchinsky avatar dkulchinsky commented on June 12, 2024

ohh, wonderful! can't wait for the next release 😄

from openunison-k8s-login-oidc.

mlbiam avatar mlbiam commented on June 12, 2024

Annotations are now supported on the Ingress from the Helm chart

from openunison-k8s-login-oidc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.