Comments (8)
Bjarni wrote:
since this should speed up NPF, we better get it in the next release, so I set it to due in 0.4.5
This comment was imported from FlySpray: https://bugs.openttd.org/task/13#comment8
from openttd.
matthijs wrote:
Making good progress. I've fully implemented the new memory pool, and the code compiles again.
What still needs to be done is push the new memory pool into NPF (trivial) and find memory manipulations in the code that should be handled by the new pool. In the old pool, objects would be marked as free, a station would get their xy property set to 0 for example. For the new pool to operate efficiently, it needs to know when a drop is no longer needed. When this does not happen, the game will not crash, but the memory will not be properly reused. Also, there are still a few bugs in the code.If you wanna take a look, please do at http://kat.student.utwente.nl/~matthijs/openttd/mempool.diff (above link is also still available).
This comment was imported from FlySpray: https://bugs.openttd.org/task/13#comment18
from openttd.
matthijs wrote:
Moving due version to .4.6, since it still needs plenty of testing in the nightlies.
This comment was imported from FlySpray: https://bugs.openttd.org/task/13#comment27
from openttd.
matthijs wrote:
This code compiles and runs. It does require a thorough check and testing, however.
I will thoroughly read it through, but I will not have too much time for thorough testing. Anyone willing to run with this patch applied is encouraged to do so and eport any weird or changed behaviour.
There is currently one know issue with this implementation: shutting down a game takes too long. This is because proper cleanup code is always run for every object in a pool, even when not really necessary. For example, for every vehicle deleted, their orders are deleted individually, just before all orders are deleted. Stuff like that.
Attachments
- mempool.diff (175.70 KiB)
This comment was imported from FlySpray: https://bugs.openttd.org/task/13#comment248
from openttd.
matthijs wrote:
For my own and your reference: Above patch was created against r4648 (the r313 in the .diff is from my local svk mirror)
This comment was imported from FlySpray: https://bugs.openttd.org/task/13#comment448
from openttd.
matthijs wrote:
So far, TrueLight has been adding parts of above giant patch to trunk. Most work is done, I'm trying to do the last pieces this or next week.
This comment was imported from FlySpray: https://bugs.openttd.org/task/13#comment676
from openttd.
Rubidium wrote:
Looks like Matthijs is taking a even bolder approach:
http://git.openttd.org/cgi-bin/gitweb.cgi?p=matthijs/trunk.git;a=shortlog;h=mempool
This comment was imported from FlySpray: https://bugs.openttd.org/task/13#comment1714
from openttd.
SmatZ closed the ticket.
Reason for closing: Implemented
After many codechanges, switching to C++ coding-style, OldPool was finally replaced by Pool in r16378.
This comment was imported from FlySpray: https://bugs.openttd.org/task/13
from openttd.
Related Issues (20)
- [Bug]: Vehicle::motion_counter for articulated train engine parts no longer updated due to #12229
- [Bug]: Desync errors since 14.0 HOT 11
- [Bug]: Station/industry nearby industry lists can become incorrect after BuildOilRig is called
- [Bug]: Timer period modifications may violate invariants of TimerManager::base_timer_sorter std::set sorting
- [Bug]: ``screenshot minimap`` is stored incorrect place in dedicated server HOT 2
- [Crash]: Assertion failed at line 114 of D:\\a\\OpenTTD\\OpenTTD\\src\\core\\pool_type.hpp: index < this->first_unused HOT 4
- [Bug]: Passengers are not accepted by all industrial factories HOT 7
- [Bug] Avatar skin color should be a dropdown menu instead of racial selectors HOT 8
- [Crash]: "id": 3221225477, "reason": "EXCEPTION_ACCESS_VIOLATION" - OpenTTD_crash20240423150954 HOT 1
- [Bug]: Unbunch breaks CargoDist HOT 1
- [Bug]: Possible race condition in WinHTTP backend
- [Bug]: Updates on admin port are unreliable
- [Bug]: GSText maximum params HOT 1
- [Crash]: Unhandled exception in ottd:game thread: invalid stoul argument HOT 2
- [Bug]: No descriptive error message when building incorrect station layout using drag-and-drop
- Help for translating Basque (i18n issues) HOT 13
- [Bug]: No descriptive error when hostile takeover fails due to vehicle limit HOT 2
- [Crash]: Out of Memory HOT 3
- [Crash]: Segmentation fault on dedicated server launch (Linux arm64) HOT 2
- [Bug]: Incorrect length of block section in a diagonal tracks HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openttd.