Fails when using Spring Webflux about java-spring-web HOT 9 CLOSED

Only partially, I did add condition to new config class for client, but did not touch ServerTracingAutoConfiguration.
So, add @ConditionalOnClass(Servlet.class) and you're done.

from java-spring-web.

@geoand Of course, same can be achieved by <exclusions> when referenced by ot-spring-cloud. Still, does not do any harm either.

from java-spring-web.

No, thanks for reporting. Do you have any error logs/reproducer? Would you like to submit a fix for it?

from java-spring-web.

I can take a look at submitting a fix sure, I’ll open a PR soon

from java-spring-web.

@darrenhaken thanks 👍

from java-spring-web.

I believe that TracerAutoConfiguration and TracerRegisterAutoConfiguration does not belong in this library (java-spring-web) at all. Then this jar can be for webflux app excluded completely (and possibly new designed for reactive stack should be created).

However, for easier -starter integration, it I suggest adding @ConditionalOnClass. Its easy change on its own, but adding tests will be more time consuming.

• Add @ConditionalOnClass(Servlet.class) to ServerTracingAutoConfiguration
• Add @ConditionalOnClass(RestTemplate.class) to RestTemplateAutoConfiguration
• Add @ConditionalOnClass(AsyncRestTemplate.class) to AsyncRestTemplateAutoConfiguration

Change is in commit f7fff3e

from java-spring-web.

@mdvorak is this resolved by #68 ?

from java-spring-web.

Sorry for being late to the party but I don't see any indication that the module supports Spring 5 yet, much less Webflux which is a non-Servlet Web framework of it's own.

Am I missing something obvious here?

from java-spring-web.

I have created #72. Webflux support will need a separate instrumentation for both client and server side.

from java-spring-web.