getting Stream Closed exception about otj-pg-embedded HOT 6 CLOSED

Hi devs @stevenschlansker @mikebell90 @gokceyucel @nedtwigg @pennello, I think the best to solve this are modify ProcessOutputLogger and add a new condition before the readLine. I tried to create a pull request for it, but I do not have permission to create branches.

            try {
                //Stop read when the buffer is empty
                if (!reader.ready()) {
                    return;
                }
                logger.info(reader.readLine());
            } catch (IOException e) {
                logger.error("while reading output", e);
                return;
            } finally {
                try {
                    reader.close();
                } catch (final IOException e) {
                    logger.error("caught i/o exception closing reader", e);
                }
            }

from otj-pg-embedded.

Thanks for writing in. @pennello committed that one so he'll probably make the call. I think your solution is still faulty and has a race, so it's not really a solution - a bandaid.

from otj-pg-embedded.

when can i expect a fix for this. It not really nice to see unwanted exceptions in your tests. It becomes more misleading when there is an exception but the program still continues.

from otj-pg-embedded.

Hey all, I think this is addressed by #69.

@pandey-vikesh

but why do i see this exception?

The reason is that we made a mistake in our implementation of the ProcessOutputLogger. Accidentally, we unconditionally closed the reader just after reading the first line! Oops!

when can i expect a fix for this.

Now! : ]

It not really nice to see unwanted exceptions in your tests. It becomes more misleading when there is an exception but the program still continues.

Totally agreed; this has been annoying us too.

@Zavierazo

but I do not have permission to create branches

Note that if you wanted, you could still have created a branch by forking the repo.

from otj-pg-embedded.

To clarify @pandey-vikesh we released 0.11.1 to fix the stream closed issue. Closing, but feel free to reopen if it doesn't solve your problem.

from otj-pg-embedded.

from otj-pg-embedded.