Comments (6)
The only issue with that is that the search system is built as a multi-backend infrastructure with code being shared among the different search engines as much as possible. So moving one to client side means breaking that shared code approach.
That said, it may well be that we can drop the other search engines now - they were important in the early days but our data is probably rich enough to stand alone now.
Either that or we can move the whole thing to the client.
from openstreetmap-website.
I'd support removing the other engines (principally Geonames). 95% of the time, Nominatim returns the right result; for the remaining 5%, being able to get there via Geonames is actually a disincentive to add the place to OSM.
from openstreetmap-website.
Geonames is the main one sure, but there are also several postcode search engines as well.
from openstreetmap-website.
If there is only one search backend, would you be OK with the search going directly from the client to nominatim and not through the rails_port?
I am wondering as (if I remember correctly) one of your main comments / complaints about the original routing integration into osm.org was that it called the routing engine backend directly from the client javascript code. I never quite understood why it was preferable to route everything through the rails backend, but because of that Frederik rewrote the routing integration to redirect everything through the rails_port code.
Did Frederik and I misunderstand you back then? Or has your opinion on this changed? Or is the routing code a different situation that doesn't compare to this one?
from openstreetmap-website.
I may be remembering wrongly, but I suspect it was the HTML code for the interface that I wanted as a proper part of the rails code rather than as a static HTML file.
I don't think I objected to having the client get the actual route directly, but I might be wrong.
from openstreetmap-website.
Speaking for the Nominatim part only: Main issue with that is the descriptive term in front of the search result. Nominatim only delivers a class/type pair (i.e. the key and value of the main tag) which is translated and localized into the descriptive term by rails. So, in order to get this on the client side, you'd have to translate half the locale ymls to javascript.
There is this vague idea in my head to move the entire logic about descriptions into Nominatim but it needs some investigating if that is feasible (and wanted, for that matter). May I suggest you hold off rewriting the rails code until I've had time to look into that?
from openstreetmap-website.
Related Issues (20)
- Scale bar in bottom corner too small to be useful HOT 14
- Login screen for OAuth 2 authorization shows "sign up" tab that triggers googles android policy violation bot HOT 15
- API documentation for /api/0.6/changeset/#id.json doesn't match actual API output HOT 10
- Add the possiblity to show the password HOT 3
- Move 'could not log you in'-message closer to the actual login button HOT 5
- Redesign User Diary Page Grid Using Bootstrap Grid and Cards HOT 3
- Test failures on issues pagination HOT 6
- Update Copyright Page HOT 9
- An old deleted GPS trace is still visible on the rendered GPS traces map HOT 6
- Strange error message for not found changeset ID
- Make gnis:feature_id clickable HOT 2
- Unpermitted parameter warning in changesets#index action HOT 9
- The Ruby API ignores getting a specific version of an object in a Multi Fetch request HOT 7
- Notify users if their account is deleted HOT 9
- website not entirely in English HOT 2
- translation of Osm:Site.key.table.entry.stop HOT 4
- split Javascripts.share.image_dimensions to allow translations
- number of Blocks Given HOT 1
- some translated strings don't appear HOT 1
- buttons on userpages visible after logging out HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openstreetmap-website.