Git Product home page Git Product logo

Comments (6)

tomhughes avatar tomhughes commented on September 17, 2024

The only issue with that is that the search system is built as a multi-backend infrastructure with code being shared among the different search engines as much as possible. So moving one to client side means breaking that shared code approach.

That said, it may well be that we can drop the other search engines now - they were important in the early days but our data is probably rich enough to stand alone now.

Either that or we can move the whole thing to the client.

from openstreetmap-website.

systemed avatar systemed commented on September 17, 2024

I'd support removing the other engines (principally Geonames). 95% of the time, Nominatim returns the right result; for the remaining 5%, being able to get there via Geonames is actually a disincentive to add the place to OSM.

from openstreetmap-website.

tomhughes avatar tomhughes commented on September 17, 2024

Geonames is the main one sure, but there are also several postcode search engines as well.

from openstreetmap-website.

apmon avatar apmon commented on September 17, 2024

If there is only one search backend, would you be OK with the search going directly from the client to nominatim and not through the rails_port?

I am wondering as (if I remember correctly) one of your main comments / complaints about the original routing integration into osm.org was that it called the routing engine backend directly from the client javascript code. I never quite understood why it was preferable to route everything through the rails backend, but because of that Frederik rewrote the routing integration to redirect everything through the rails_port code.

Did Frederik and I misunderstand you back then? Or has your opinion on this changed? Or is the routing code a different situation that doesn't compare to this one?

from openstreetmap-website.

tomhughes avatar tomhughes commented on September 17, 2024

I may be remembering wrongly, but I suspect it was the HTML code for the interface that I wanted as a proper part of the rails code rather than as a static HTML file.

I don't think I objected to having the client get the actual route directly, but I might be wrong.

from openstreetmap-website.

lonvia avatar lonvia commented on September 17, 2024

Speaking for the Nominatim part only: Main issue with that is the descriptive term in front of the search result. Nominatim only delivers a class/type pair (i.e. the key and value of the main tag) which is translated and localized into the descriptive term by rails. So, in order to get this on the client side, you'd have to translate half the locale ymls to javascript.

There is this vague idea in my head to move the entire logic about descriptions into Nominatim but it needs some investigating if that is feasible (and wanted, for that matter). May I suggest you hold off rewriting the rails code until I've had time to look into that?

from openstreetmap-website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.