Remove the LTR stylesheet about openstreetmap-website HOT 5 CLOSED

Unfortunately I think that will make it much harder for me to review changes to the stylesheets... Basically part of what I do when reviewing changes is:

1. Look through the diff for common.css etc to see if any rules have been added which have an unbalanced effect on left/right values and which are therefore direction specific and arrange for any such rules to be moved to ltr.css.
2. Use a visual comparison tool to look at a side by side comparison of ltr.css and rtl.css to make sure that they are same except for left and right being reversed.

Doing what you suggest will obviously render this process impossible in it's current form.

from openstreetmap-website.

I can see the benefit of that. I am going to think more about this, but for now, I'll stick with the established pattern.

Regularily jumping between multiple stylesheets makes CSS difficult to write. I wonder if there's a way to use Sass variables to reverse our left:'s to rights's and so forth. Then we only need one stylesheet, and redefine the variables based on reading direction. That could potentially be a great solution right? I don't know enough about Sass to know if this is feasible.

Edit: here's an example of how this might work: http://amitkazmirsky.com/2011/05/29/dry-your-rtl-and-ltr-css-files-in-rails-with-sass/

from openstreetmap-website.

As you discovered, yes it can be done with variables. It can also be done with mixins, as shown here:

http://anasnakawa.github.com/bi-app-sass/

Both give a result that is not exact clean though. Another option, which I'm currently investigating, is to use R2 with a shim to integrate it into the asset serving.

from openstreetmap-website.

I've created tomhughes/openstreetmap-website@2af0d2a which uses R2 to automatically reverse the stylesheet - it's running at http://tomh.apis.dev.openstreetmap.org/ if people want to test it.

from openstreetmap-website.

I merged my fix last week.

from openstreetmap-website.