Comments (10)
#111
(Having your tests in R made the whole thing easier than I was anticipating and way easier than if I had started from scratch!)
from database.
By the way, do we still need this branch : https://github.com/OpenStemmata/database/tree/transform ?
from database.
By the way, do we still need this branch : https://github.com/OpenStemmata/database/tree/transform ?
No, I just deleted it.
from database.
I'll try to get to work on this asap, while the thing is still fresh in my mind. Should I also try to "translate" your tests to python as was suggested?
It's not absolutely necessary, as we can combine R and python in one run, but it would make sense to have the whole thing use only one language - and it's hopefully faster. I don't have any experience in creating that kind of tests with python but sounds like something interesting to learn.
from database.
Well, as you wish ! It certainly makes sense, and probably should be done in the end, but, on the other hand, we've done quite some engineering in the past days, and I would judge a priority to move forward on adding new stemmata. So, it's really a matter of what you feel like doing too.
from database.
Ok, I updated the tests in #109
I am leaving the R for now.
Currently the push to main is disabled, because it is a protected branch and we would need to create a secret access token. I did it in my test repo and it works. We would need to decide if you create the token, make me an admin so that I can do it or we create a user only for this purpose. We can discuss it next time we speak. For now, I would suggest merging #109 so that we can start contributing new stemmata with the tests working hopefully without generating errors. We can create the actual TEI files after we decide what to do with the token.
from database.
Ok, let's discuss it then ! Meanwhile, I made you co-owner of the organisation, which could facilitate things !
from database.
#109 merged.
from database.
I got hooked into trying to do the tests in python and I think I did it 🥳
I tried them out in my clone repo and it seems to work really well. It takes about a minute to run, which is a great improvement!
I'll open a pull request with the code
from database.
Wahou, that was fast ! Congrats !
from database.
Related Issues (20)
- typo
- Epic Poetry Stemmata Collections
- Old Occitan HOT 1
- Validate XML files HOT 1
- German
- Add schematron rules to check metadata values (`keywords` and `terms`)
- contamination not included if "" missing HOT 2
- Post merge workflow committing ? HOT 12
- Old French Epics
- Unmarked contamination in not straightforward traditions HOT 1
- Non-oriented stemma HOT 1
- processing metadata as yaml and allowing absence of fields ?
- Different types of non-standard transmission HOT 2
- Field publicationStemmaNum not exported in tei ?
- Manuscripts in gv and not in picture (based on the text?) -- Rennewart
- Check how comments from gv are handled
- Finish to upload my old database of stemmata
- Add a Python wrapper on data
- Make it a PyPI package HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from database.