Git Product home page Git Product logo

Comments (7)

alistarle avatar alistarle commented on May 23, 2024 2

BTW I begin to work on that and already migrate half of the metrics to gophercloud, I will make a draft PR when all will be migrated.

from openstack-exporter.

niedbalski avatar niedbalski commented on May 23, 2024

@alistarle I am ok with your proposal, If you could draft a PR that we can follow up, it would be really helpful.

from openstack-exporter.

alistarle avatar alistarle commented on May 23, 2024

Thanks, here is the draft, it works but there is still a lot of work to do : #27

from openstack-exporter.

niedbalski avatar niedbalski commented on May 23, 2024

@alistarle Thank you much. Could you please review the comment on #27? Please rebase on top of the gophercloud branch and re-submit, lets work from there rather than master.

Thanks again for your work on this!

from openstack-exporter.

niedbalski avatar niedbalski commented on May 23, 2024

@alistarle

I've merged this PR and the master builds are using GopherCloud. Please let me know if this
works for you so I can do a initial release using the new gophercloud based code.

I've also added yourself to the list of contributors[1] for your great contribution implementing
this feature.

Feel free to send me PR(s) if I missed any detail or if you have any new metrics that
you think might be useful.

[0] #30
[1] https://github.com/openstack-exporter/openstack-exporter/blob/master/CONTRIBUTORS.md

from openstack-exporter.

niedbalski avatar niedbalski commented on May 23, 2024

I am closing this bug as no other feedback has been provided. Feel free to open a new issue if you find any bug or missing implementation.

Thanks!

from openstack-exporter.

alistarle avatar alistarle commented on May 23, 2024

Sorry I was not available these days, but thanks for merging this code ! I will test this week then add some metrics I was looking for for moving to gophercloud

from openstack-exporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.